-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right to Vanish #1256
base: master
Are you sure you want to change the base?
Right to Vanish #1256
Conversation
Co-authored-by: fiatjaf_ <fiatjaf@gmail.com>
Starting over from scratch from one point in time onwards is a good feature. Considering that an user could change their mind by using a @vitorpamplona have you considered merging the two kinds into a single parameterized replaceable event with the |
I am against the merge because the second event kind is much more dangerous than the first. Keeping things separate should avoid some mistakes but clients (like forgetting to set the relay or d tag) |
Add a switch so that if tags is empty - delete all if a tag list is included - delete only those tags associated with the pubkey. Note: I understrand that the additional granularity is outside the "Right to Vanish" scope. |
I also like @arthurfranca's idea but instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice! Required, I think, for relays in the EU that want to be GDPR compliant. Also the Apple App Store has a rule that you must offer the user a way to delete their account, and this seems like a best-effort way to adhere to that rule, given that you can't force other people to delete your data.
CC @jb55 I think you publish some kind of account deletion event in Damus to comply with the Apple rules. Curious what you think of this. |
Ok, unified the two kinds in one with the ALL_RELAYS tag as requested. |
But it was supposed to be a A PRE fits nicely because the proposed event is unique per relay url. |
It can't. The event can have more than one target relay. |
If I'm relay "A", references to relays "B", "C", ..., "Z" are bytes I don't want to store. Contrary to what happens in most other use cases, this one benefits from splitting many references into individual events. |
If that is the case, you probably also don't want to maintain an entry in the replaceable address index for this event in case the user sends a new one. Deletion events should not be replaceable. |
An event replacing the older one would effectively extend the "until" period. Isn't it desired? |
Yes, but we don't need the infrastructure of replaceable events to do that. The regular 62 will delete past 62s as well. |
Replaceable events infra is already in place (NIP-01), no extra lines of code for the replacement logic. |
My point is that we don't need to do replacement + deletion logics. Deletion logic is already enough. Clients that don't implement replaceable events don't need to implement it. |
Though.. a newer You have a point, the replacement logic can't rely solely on PRE flow. |
Got it, if it replaces everything that came before, it replaces older 62. I was wrong. |
I don't really believe in a universal "right to vanish" for distributed protocols.
All that said, I suppose for those who do want to allow for deletion, or those that have to in order to comply with some laws, it's good to have a standard for this. Some feedback: I feel like "Delete Account" is a bad name for this. You're still going to have your pubkey, and all of your followers. And all of your content, on relays that aren't targeted. It's more like "Delete Content Before X From Server Y". And "Right To Vanish" is … just the same thing targeted at all relays. Maybe "Delete Content [From Relay]" and "Reset Account" are better terms for what these two cases accomplish? If you want a real Delete Your Account, it should be an irrevocable revocation of the pubkey. Something like:
Advantages:
Footnotes |
I like this. 👍 |
It's a welcome feature. Given the recent terminology change on nip-09 from "delete" to "deletion request" is any terminology update needed here? E.g. "right to vanish" -> "request to vanish" |
Request to vanish sounds good |
- Added deletion of GiftWrapped DMs - Reduced duplications from the merge of the two separate events in the past.
# Conflicts: # README.md
Adjusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, somehow I posted a review on this PR which was intended for planetary-social/nos#1518. Anyway we are implementing this in Nos now. strfry PR to follow. I would like to see this merged in the near future.
NIP-62 | ||
====== | ||
|
||
Request to Vanish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this mostly called right to be forgotten in the internet. i think we can consider this as a better name. RTBF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do either. I was reticent to use "forgotten" because deleting stuff from relays doesn't mean you will be "forgotten". It just means that your data was deleted from that instance or instances that received this event and comply to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree and it's logical. but i think this is same for other stuff on web and internet, and using forgotten
just makes it easier ti understand for people from everywhere. im more agree with forgotten
or maybe something between. we can think more about the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found this: https://en.wikipedia.org/wiki/Right_to_be_forgotten.
they call it vanish as well. we can use one of them and include other one on details of standard. maybe.
62.md
Outdated
} | ||
``` | ||
|
||
Clients SHOULD broadcast this event to as many relays as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it ok with line 41?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guidance is only for the "ALL_RELAYS" option. Otherwise, line 41 should be taken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. thanks a lot.
Co-authored-by: K <kehiiiiya@gmail.com>
Co-authored-by: K <kehiiiiya@gmail.com>
What would deleting a |
Either that or we just don't allow deletions. Deleting kind 62 allows the user to fix potential mistakes, but it also allows an attacker that has access to an nsec to restore everything to its full glory. I am leaning more towards disallowing kind 62 to be deleted in the same way we don't allow kind:5 to delete other kind 5s |
Agree with disallowing to delete kind 62. Either one should be probably mentioned in nip to avoid ambiguity |
This NIP has been deployed in the latest version of Nos and relay.nos.social. Unfortunately we didn't make a PR directly to strfry. We instead went with a strfry plugin that pushes kind 62 events to a redis stream where they are processed by all our systems (NIP-05, push notification service, and a script that deletes events from strfry). But it's all open source and we have a docker compose file if anyone wants to copy it. @vitorpamplona have you added this to Amethyst yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is needed and the framing of it is right.
Not yet, but will do soon. I usually wait for somebody else to code the NIPs I propose to confirm that my idea is not just complete trash. :) |
This has the same problem that allowing tagged users to delete events has, which is that it completely breaks all use of shared keys. In #875, all members of a group share a key. This allows anyone to post to the group, but with this PR it would allow all members of the group to delete all the other members' posts. While NIP 87 is likely going away, I also don't think it's the only valid use of a shared pubkey. We should see if the gift-wrap part of this PR can be handled some other way. |
This has been deployed to https://relay.netstr.io/ |
Never mind, shared keys are already broken. What we need to fix it is a mechanism to say events can't be deleted by the author, or the recipient. I rescind my objection. |
Adds a special event kinds for relays to allow for
Read here