-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Draft Event #1124
base: master
Are you sure you want to change the base?
Generic Draft Event #1124
Conversation
It may be useful to require an one-letter tag set to an event id/address when it is a comment/reply/referrer draft or empty string when "root" draft, like |
Good point, I have added anchor events. I don't think we can ask to have empty |
I almost like this, but the e/a tags make me think that this should probably not be generic; drafts should be specified by kind number on a case-by-case basis, since you may want to search for something other than the anchor. |
People can add other tags to this event at will. These are just the basic ones. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking to have encrypted url attachments but I think I can just add these to the inner draft and remove them when posting. This works for me!
@mikedilger curious to hear your feedback from the Private Relay list section here. The idea is to have a list of relays to store events that only the author should see. A private outbox if you will. |
I wonder if it's creating an event for ever letter people type
It is. The goal for this event is to be saving drafts as people type so that if apps crash they never lose anything. Amethyst sends a new version in 1 second after the user stops typing if there is a change to the event.
Maybe this is the first real use of replaceables we have seen in Nostr.
|
@vitorpamplona I've been having problems with uptime. I haven't been able to narrow it down yet, but I imagine this draft event isn't helping. I get huge bursts of draft events, presumably when people on Amethyst are typing: Is it really sending on every keystroke? It's not even debounced? That seems like a performance problem for both relays and users of Amethyst. It would make more sense to wait 5 seconds until the user has stopped typing to publish the draft event to other relays. |
It is denounced at every second. What's the chart saying? How many events are in that peak? I can't quite figure it out. And what's the green line? |
fyi: I also see a lot of those events in our NWC only rely (we reject those events) |
Adds a private draft event kind for any other event type. Clients can search by supported kinds via the
k
tagRead here