Translate nip07 #82
Merged
Translate nip07 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penpenpng
reviewed
Jan 6, 2024
こちらは現時点ではそのままで問題ないはずです🙆♂ |
|
@penpenpng 指摘を取込みました。ご確認お願いします🙇 |
darashi
approved these changes
Jan 6, 2024
Co-authored-by: penpenpng <poman1638m@gmail.com>
darashi
force-pushed
the
translate-nip07
branch
from
ce12aa9 to
03a5139
Compare
|
✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
レビューをよろしくお願いいたします。
なお、
commit id: aaed343
に対する
npm run lintで CONTRIBUTING.md のですます調について指摘されますが、一旦対応していません。linterの解析対象外にすべきなのか、であるで統一すべきなのか不明瞭であったこと、
今回のPRの対象にしてしまうとPRの名前に対し対応内容が大きすぎると考えたためです。
対応方針がわかれば別issue→PRを切って対応させていただければと思いますので、
対応方針もコメント頂けますと幸いです。