Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove and untrack css #98

Merged
merged 1 commit into from
Dec 7, 2018
Merged

remove and untrack css #98

merged 1 commit into from
Dec 7, 2018

Conversation

abdallahalsamman
Copy link
Member

closes #97

No more css conflicts everybodyyy 🎉 🎉

@BcRikko BcRikko added the devops CI, build, and deployment issues label Dec 7, 2018
trezy
trezy requested changes Dec 7, 2018
View reviewed changes
Copy link
Member

@trezy trezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this would also break deployments since the css folder wouldn't be included when the package gets published to npm. To fix that, please add a .npmignore file. 😉

@trezy trezy mentioned this pull request Dec 7, 2018
Merged
@trezy trezy added the waiting - contributor Waiting for the contributor to address some situations label Dec 7, 2018
@abdallahalsamman
Copy link
Member Author

@trezy the goal of this PR was to get rid of conflicts caused by the css build, adding css to .npmignore is not going to solve that.

Does this go inline with what you were saying? or have I misunderstood you at some point?

@trezy
Copy link
Member

trezy commented Dec 7, 2018

@evexoio Yeah, I think you misunderstood. Here are what the two files should look like when you're done:

.gitignore

node_modules
.vscode
css
storybook-static

.npmignore

node_modules
.vscode
storybook-static

That way the css folder won't be included in commits, but it will be included when we publish to npm. 😉

@abdallahalsamman
Copy link
Member Author

@trezy ok I get you now, npm goes with .gitignore if .npmignore is not found. thanks 🙌

trezy
trezy approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@trezy trezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trezy trezy merged commit 5f957bd into nostalgic-css:develop Dec 7, 2018
@BcRikko
Copy link
Member

BcRikko commented Dec 18, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@guastallaigor guastallaigor removed the waiting - contributor Waiting for the contributor to address some situations label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trezy trezy trezy approved these changes

Assignees
No one assigned
Labels
devops CI, build, and deployment issues released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove and ignore css
4 participants
@abdallahalsamman @trezy @BcRikko @guastallaigor