-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove and untrack css #98
remove and untrack css #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this would also break deployments since the css
folder wouldn't be included when the package gets published to npm. To fix that, please add a .npmignore
file. 😉
@trezy the goal of this PR was to get rid of conflicts caused by the css build, adding Does this go inline with what you were saying? or have I misunderstood you at some point? |
@evexoio Yeah, I think you misunderstood. Here are what the two files should look like when you're done: .gitignore
.npmignore
That way the |
@trezy ok I get you now, npm goes with |
b4a53ca
to
9c19dd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #97
No more css conflicts everybodyyy 🎉 🎉