Add google icon #76
Closed
Add google icon #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a CircleCI config file based on the same config I use for my own website. It makes it easy to have multiple steps running in parallel, such as running tests and coverage reports.
Forcing contributors to use Commitizen to format their commit messages will make our lives much simpler, especially once we've added `semantic-release`.
Add `semantic-release` to the repo and the build pipeline. This will handle automatically publishing to npm based on commit messages. nostalgic-css#13
The Roll For Guild Node container doesn't include `git`, which is required by semantic-release. nostalgic-css#13
I got a bunch of permission errors last time I tried to build in ~/app. I'm pretty sure building in the default directory should work just as well.
I've removed containers from tthe config entirely because I don't think we need them. Hopefully this will fix the build. 🤷🏻♂️
Switching back to container because I have no idea how to fix the errors that came up without them. Additionally, I'm changing the working directory to `~/tmp` to see if that works better than the `~/app` folder.
I think the issue was that the app was being built into the root user's home directory rather than the `circleci` user's home directory. 🤞
I finally figured it out. Restoring the cache was trying to restore the cache from an older build that used a different image in which the root user was the one doing all the tasks. I'm pushing a build that doesn't restore the cache, then I'll add those steps back in after the next build.
By removing strict host key checking for Github, we shouldn't run into the issue where host authenticity verification stalls the deployment.
Repository cloning in the deploy step was 100% unnecessary.
Add `commitlint` to enforce proper formatting for all commit messages nostalgic-css#13
I've updated the `package.json` so it points back at @BcRikko's repo instead of mine. nostalgic-css#13
Set up Commitizen, CircleCI, and `semantic-release`
BcRikko
added
enhancement
|
Thanks 🙇 |
|
I counted the number of bytes in so please give me some time to merge your PR 🙇 |
|
Hey @guastallaigor, make sure to merge the latest version of the |
|
I need some time to fix the commit history with this PR and resolve conflicts with develop. After work I will do it and get back to you. Thank you. |
|
I will close because I opened a new one (#96). |
guastallaigor
removed
the
waiting - contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you think it's fine here it is. Otherwise I can make some changes.
One more for #65 .