Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README English translation #46

Merged
merged 2 commits into from
Dec 1, 2018
Merged

README English translation #46

merged 2 commits into from
Dec 1, 2018

Conversation

Baldomo
Copy link
Contributor

@Baldomo Baldomo commented Nov 30, 2018

I translated the original README in English as best as I could. I'll be waiting for feedback as I don't really know Japanese. I also updated the directory listing with symbols from tree and linked the two READMEs to each other with the links on top.

PS: I left the TODOs in Japanese, I don't think users would find them useful.

@BcRikko
Copy link
Member

BcRikko commented Nov 30, 2018

Thanks 😍

I merged #31 , could you check this PR again? 🙏
It's OK to split README(English-only and Japanese-only) 👍

@BcRikko BcRikko self-requested a review November 30, 2018 23:48
@BcRikko BcRikko added the documentation Adding, removing, or updating documentation label Dec 1, 2018
@Baldomo
Copy link
Contributor Author

Baldomo commented Dec 1, 2018

I will update my fork once I'm back home

@Baldomo
Copy link
Contributor Author

Baldomo commented Dec 1, 2018

@BcRikko I pulled the new READMEs from master and split them, let me know.

@BcRikko BcRikko merged commit 1e239a3 into nostalgic-css:master Dec 1, 2018
@BcRikko
Copy link
Member

BcRikko commented Dec 1, 2018

Thanks 🙇
LGTM 🎉

@BcRikko
Copy link
Member

BcRikko commented Dec 18, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Adding, removing, or updating documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants