Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table design #41

Merged
merged 7 commits into from
Nov 30, 2018
Merged

Conversation

guastallaigor
Copy link
Member

This address #35 .

image


If you want to change something, please just let me know. Thank you.

@BcRikko BcRikko self-requested a review November 30, 2018 10:34
@BcRikko BcRikko added the enhancement New feature or request label Nov 30, 2018
Copy link
Member

@BcRikko BcRikko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍
Greate table design 🎉

I wrote comments so please check them. 📝

scss/elements/tables.scss Outdated Show resolved Hide resolved
scss/elements/tables.scss Outdated Show resolved Hide resolved
scss/elements/tables.scss Show resolved Hide resolved
scss/elements/tables.scss Show resolved Hide resolved
@guastallaigor
Copy link
Member Author

Thank you for your review. Sorry I'm not very good with CSS.

I will make all the changes at my lunch break.

@BcRikko
Copy link
Member

BcRikko commented Nov 30, 2018

Don't worry, me too 😆
CSS is so difficult...

I'm waiting for your new commit 😍

…e $base-color variable, added word-wrap property and removed the box-shadow unused values.
Copy link
Member

@BcRikko BcRikko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙇

LGTM 🎉

@BcRikko BcRikko merged commit da802a1 into nostalgic-css:master Nov 30, 2018
@BcRikko
Copy link
Member

BcRikko commented Dec 18, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants