-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable font-smoothing #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
I didn't know font-smoothing
property 😆
I commented, please confirm 🙏
scss/base/reboot.scss
Outdated
@@ -17,6 +17,7 @@ html { | |||
-webkit-text-size-adjust: 100%; | |||
-ms-overflow-style: scrollbar; | |||
-webkit-tap-highlight-color: rgba(0, 0, 0, 0); | |||
-webkit-font-smoothing : none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this code to scss/base/generic.scss
🙏
I don't want to change reboot.scss, because I copy and use Bootstrap Reboot v4.1.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, I moved it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
LGTM 🎉
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Just a tiny change to remove the anti-aliasing from the font :)
Currently:
Without font-smoothing: