Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README-es file #394

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Update the README-es file #394

merged 1 commit into from
Jan 5, 2020

Conversation

OswaldoPineda
Copy link
Contributor

Description
This translates 2 lines to keep the language on the whole page.

Compatibility
This change is compatible, it doesn't affect the code.

BcRikko
BcRikko previously approved these changes Jan 5, 2020
Copy link
Member

@BcRikko BcRikko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😆
LGTM 🎉

@BcRikko
Copy link
Member

BcRikko commented Jan 5, 2020

@OswaldoPineda Thanks 👍
But unfortunately commitlint has failed...

Could you change your commit message to something like docs: update the readme-es file 🙇

# edit your commit message
$ git commit --amend -m "docs: update the readme-es file"

# force push branch
$ git push --force-with-lease origin patch-1

@BcRikko BcRikko added the documentation Adding, removing, or updating documentation label Jan 5, 2020
Copy link
Member

@BcRikko BcRikko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

@BcRikko BcRikko merged commit 7750271 into nostalgic-css:develop Jan 5, 2020
@OswaldoPineda OswaldoPineda deleted the patch-1 branch January 6, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Adding, removing, or updating documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants