feat: Add column renderer templates for all columns #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
changed the title
aslafy-z
changed the title
aslafy-z
changed the title
aslafy-z
changed the title
aslafy-z
force-pushed
the
patch-1
branch
3 times, most recently
from
f2e0aa8 to
d2235f4
Compare
Signed-off-by: GitHub <noreply@github.com>
|
@norwoodj can you give a look to this PR? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract markdown tables columns into new templates:
valueKeyColumnRenderMdvalueTypeColumnRenderMdvalueDefaultColumnRenderMdvalueDescriptionColumnRenderMdRename
valuesSectiontovaluesSectionMdwhile keeping a proxy template.Rename
valuesTabletovaluesTableMdwhile keeping a proxy template.Extract HTML tables columns into new templates:
valueKeyColumnRenderHtmlvalueTypeColumnRenderHtmlvalueDescriptionColumnRenderHtmlRename
valueDefaultColumnRendertovalueDefaultColumnRenderHtmlwhile keeping a proxy template.Deprecate fields:
valueKeyColumnRendervaluesSectionvaluesTableAdd
--document-dependency-valuesin the pre-commit hooks soexample-charts/umbrellagets correctly generated.There's a lot of noise to keep backward compatibility.