Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support section description through user-defined templates #234

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pkoutsovasilis
Copy link

This PR is a PoC of how user-defined templates could be incorporated to support writing a description between the Section header and values table.

An example of this can be found here

@pkoutsovasilis pkoutsovasilis force-pushed the feat/section_descriptions branch from 57468aa to 8a5a32d Compare June 5, 2024 22:41
@norwoodj
Copy link
Owner

norwoodj commented Jul 6, 2024

Hello, sorry for the slow response. I like the idea here, but why do the descriptions need to be templates? It seems unnecessarily complex. I would merge a PR which allowed you to simply specify, for instance:

# -- This is some value
# @section -- Section 1
# @sectionDescription -- This is a description for the first section

I'm not convinced that this is any worse or limiting than allowing users to specify templates, and I think it's much easier for users to understand.

@norwoodj norwoodj added the enhancement New feature or request label Jul 6, 2024
@pkoutsovasilis
Copy link
Author

Hello, sorry for the slow response. I like the idea here, but why do the descriptions need to be templates? It seems unnecessarily complex. I would merge a PR which allowed you to simply specify, for instance:

# -- This is some value
# @section -- Section 1
# @sectionDescription -- This is a description for the first section

I'm not convinced that this is any worse or limiting than allowing users to specify templates, and I think it's much easier for users to understand.

Hi 👋 the only small reason I have against your proposal is that at the end of the day the crucial bit of a values.yaml for someone is being able to read and write the actual values. To this end, I always find it kinda tricky to have the right amount of meta comments that do not hinder the aforementioned. Thus to me a description of the section feels better handled by the user in their template.

However, I can give your proposal a try and see what this looks like 🙂

@wrenix
Copy link

wrenix commented Sep 12, 2024

How to create a Section 1-Values template (without redefine the Table template)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants