Make Player.GameObject nullable and null check ReferenceHub before accessing it. - #144
Merged
Merged
Conversation
brayden-dowson
approved these changes
May 24, 2025
Contributor
|
This shouldn't be needed as players are subscribed to ReferenceHub.OnPlayerRemoved. |
Contributor
Author
This doesn't prevent invalid players when using coroutines. |
Jesus-QC
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering
ReferenceHubcan be null/destroyed, this would avoid exceptions just from accessingPlayer.GameObjectwhile it's not valid.