Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: Pull MOL* dependencies back in #243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

russellhancox
Copy link
Member

The MOL* dependencies were originally written as part of Santa and separated out into distinct project to make them easier to share with other projects. Instead of making forks of these projects we're pulling them back into Santa so we can more easily make changes to suit Santa's needs.

I haven't made any changes to the source inside the MOL* files except to fix imports.

The MOL* dependencies were originally written as part of Santa and
separated out into distinct project to make them easier to share with
other projects. Instead of making forks of these projects we're pulling
them back into Santa so we can more easily make changes to suit Santa's
needs.
@russellhancox russellhancox requested a review from a team as a code owner February 6, 2025 22:33
@github-actions github-actions bot added comp/santad Issues or PRs related to the daemon comp/gui Issues or PRs related to the Santa GUI comp/santasyncservice Issues or PRs related to the sync protocol comp/santactl Issues or PRs related to santactl lang/objc PRs modifying files in ObjC lang/objc++ PRs modifying files in ObjC++ comp/santabundleservice Issues or PRs related to the bundle service comp/santametricservice Issues or PRs related to the metric service comp/common size/xl Size: extra large labels Feb 6, 2025
#import <Network/Network.h>
#import "Source/common/MOLXPCConnection.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import grouping

#import "Source/common/SNTCommonEnums.h"
#import "Source/common/SNTConfigurator.h"
#import "Source/common/SNTMetricSet.h"

#import <MOLAuthenticatingURLSession/MOLAuthenticatingURLSession.h>
#import <OCMock/OCMock.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import grouping

@@ -14,8 +15,7 @@

#import "Source/santad/DataLayer/SNTEventTable.h"

#import <MOLCertificate/MOLCertificate.h>

#import "Source/common/MOLCertificate.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import grouping

@@ -15,8 +15,7 @@

#import "Source/santactl/SNTCommandController.h"

#import <MOLXPCConnection/MOLXPCConnection.h>

#import "Source/common/MOLXPCConnection.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import grouping

@@ -17,10 +17,10 @@
#include <Foundation/Foundation.h>
#include "Source/common/SNTCommonEnums.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import grouping

@@ -15,7 +16,7 @@
#include <cstdint>
#include <iostream>

#import <MOLXPCConnection/MOLXPCConnection.h>
#import "Source/common/MOLXPCConnection.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import grouping

@@ -15,7 +16,7 @@
#include <cstdint>
#include <iostream>

#import <MOLXPCConnection/MOLXPCConnection.h>
#import "Source/common/MOLXPCConnection.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import grouping

@@ -15,7 +16,7 @@
#include <cstdint>
#include <iostream>

#import <MOLXPCConnection/MOLXPCConnection.h>
#import "Source/common/MOLXPCConnection.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import grouping

@@ -15,6 +15,8 @@

#import "Source/common/CertificateHelpers.h"

#import "Source/common/MOLCertificate.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import grouping

Source/common/testdata/cal-yikes-universal Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/common comp/gui Issues or PRs related to the Santa GUI comp/santabundleservice Issues or PRs related to the bundle service comp/santactl Issues or PRs related to santactl comp/santad Issues or PRs related to the daemon comp/santametricservice Issues or PRs related to the metric service comp/santasyncservice Issues or PRs related to the sync protocol lang/objc PRs modifying files in ObjC lang/objc++ PRs modifying files in ObjC++ size/xl Size: extra large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants