-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project: Pull MOL* dependencies back in #243
base: main
Are you sure you want to change the base?
Conversation
The MOL* dependencies were originally written as part of Santa and separated out into distinct project to make them easier to share with other projects. Instead of making forks of these projects we're pulling them back into Santa so we can more easily make changes to suit Santa's needs.
#import <Network/Network.h> | ||
#import "Source/common/MOLXPCConnection.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import grouping
#import "Source/common/SNTCommonEnums.h" | ||
#import "Source/common/SNTConfigurator.h" | ||
#import "Source/common/SNTMetricSet.h" | ||
|
||
#import <MOLAuthenticatingURLSession/MOLAuthenticatingURLSession.h> | ||
#import <OCMock/OCMock.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import grouping
@@ -14,8 +15,7 @@ | |||
|
|||
#import "Source/santad/DataLayer/SNTEventTable.h" | |||
|
|||
#import <MOLCertificate/MOLCertificate.h> | |||
|
|||
#import "Source/common/MOLCertificate.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import grouping
@@ -15,8 +15,7 @@ | |||
|
|||
#import "Source/santactl/SNTCommandController.h" | |||
|
|||
#import <MOLXPCConnection/MOLXPCConnection.h> | |||
|
|||
#import "Source/common/MOLXPCConnection.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import grouping
@@ -17,10 +17,10 @@ | |||
#include <Foundation/Foundation.h> | |||
#include "Source/common/SNTCommonEnums.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import grouping
@@ -15,7 +16,7 @@ | |||
#include <cstdint> | |||
#include <iostream> | |||
|
|||
#import <MOLXPCConnection/MOLXPCConnection.h> | |||
#import "Source/common/MOLXPCConnection.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import grouping
@@ -15,7 +16,7 @@ | |||
#include <cstdint> | |||
#include <iostream> | |||
|
|||
#import <MOLXPCConnection/MOLXPCConnection.h> | |||
#import "Source/common/MOLXPCConnection.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import grouping
@@ -15,7 +16,7 @@ | |||
#include <cstdint> | |||
#include <iostream> | |||
|
|||
#import <MOLXPCConnection/MOLXPCConnection.h> | |||
#import "Source/common/MOLXPCConnection.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import grouping
@@ -15,6 +15,8 @@ | |||
|
|||
#import "Source/common/CertificateHelpers.h" | |||
|
|||
#import "Source/common/MOLCertificate.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: import grouping
The MOL* dependencies were originally written as part of Santa and separated out into distinct project to make them easier to share with other projects. Instead of making forks of these projects we're pulling them back into Santa so we can more easily make changes to suit Santa's needs.
I haven't made any changes to the source inside the MOL* files except to fix imports.