Install GitHub #60
Install GitHub #60
Conversation
This causes different temporary paths to be generated, so any temporary paths shown in the log window won't match the ones actually used when executing the algorithm
# Conflicts: # .travis.yml # README.md # website/mkdocs.yml # website/pages/index.md # website/pages/script-syntax.md
…install packages from GitHub and then load packages from script
processing_r/processing/algorithm.py
Outdated
| packages = self.r_templates.get_necessary_packages() | ||
|
|
||
| for p in packages: | ||
| commands.append(self.r_templates.check_package_availability(p)) | ||
| commands.append(self.r_templates.load_package(p)) | ||
|
|
||
| if self.r_templates.install_github: | ||
| for dependency in self.r_templates.github_dependencies: | ||
| commands.append(self.r_templates.install_package_github(dependency)) | ||
|
|
||
| packages_script = RUtils.get_required_packages(self.script) | ||
|
|
||
| for p in packages_script: | ||
| commands.append(self.r_templates.check_package_availability(p)) | ||
| commands.append(self.r_templates.load_package(p)) | ||
|
|
There was a problem hiding this comment.
I think this whole block of code could be moved to r_templates -- what do you think?
There was a problem hiding this comment.
That makes sense, all the info is contained there anyway! I will fix it later today :)
Btw: Just out of curiosity, is there a way to add the changes to this pull request or do I have to close it and make a new one?
There was a problem hiding this comment.
If you commit them to the same branch and then push, they'll appear here automatically!
|
@JanCaha we should add this to the documentation too. When it's merged I'll push out a new release |
|
Thanks! Happy for me to push a new release off master? |
|
Of course :) Hopefully, I will remember until the morning to update the Changelog for the website ... |
This pull request introduces a new metadata line that allows the installation of R packages from GitHub via R package
remotes.The format is:
##JanCaha/CzechData, JanCaha/SpatialKDE=github_installWhich is processed just before the packages are loaded.
This quite likely very useful as there is a significant amount of packages that are not available from CRAN (for various reasons). This allows users to use these packages and declare this use formally.