Skip to content

Commit

Permalink
mfd: cs5535-mfd: Remove ifdef OLPC noise
Browse files Browse the repository at this point in the history
<asm/olpc.h> provides machine_is_olpc() stub for CONFIG_OLPC=n,
compiler should just optimize the unneeded bits away.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
  • Loading branch information
lkundrak authored and Lee Jones committed Jul 2, 2019
1 parent b1c83bd commit fd54d65
Showing 1 changed file with 7 additions and 17 deletions.
24 changes: 7 additions & 17 deletions drivers/mfd/cs5535-mfd.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,22 +112,10 @@ static struct mfd_cell cs5535_mfd_cells[] = {
},
};

#ifdef CONFIG_OLPC
static void cs5535_clone_olpc_cells(void)
{
static const char *acpi_clones[] = {
"olpc-xo1-pm-acpi",
"olpc-xo1-sci-acpi"
};

if (!machine_is_olpc())
return;

mfd_clone_cell("cs5535-acpi", acpi_clones, ARRAY_SIZE(acpi_clones));
}
#else
static void cs5535_clone_olpc_cells(void) { }
#endif
static const char *olpc_acpi_clones[] = {
"olpc-xo1-pm-acpi",
"olpc-xo1-sci-acpi"
};

static int cs5535_mfd_probe(struct pci_dev *pdev,
const struct pci_device_id *id)
Expand Down Expand Up @@ -157,7 +145,9 @@ static int cs5535_mfd_probe(struct pci_dev *pdev,
dev_err(&pdev->dev, "MFD add devices failed: %d\n", err);
goto err_disable;
}
cs5535_clone_olpc_cells();

if (machine_is_olpc())
mfd_clone_cell("cs5535-acpi", olpc_acpi_clones, ARRAY_SIZE(olpc_acpi_clones));

dev_info(&pdev->dev, "%zu devices registered.\n",
ARRAY_SIZE(cs5535_mfd_cells));
Expand Down

0 comments on commit fd54d65

Please sign in to comment.