Skip to content

Commit

Permalink
zorro: make match function take a const pointer
Browse files Browse the repository at this point in the history
In commit d69d804 ("driver core: have match() callback in struct
bus_type take a const *"), the match callback for busses was changed to
take a const pointer to struct device_driver.  Unfortunately I missed
fixing up the zorro code, and was only noticed after-the-fact by the
kernel test robot.  Resolve this issue by properly changing the
zorro_bus_match() function.

Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Fixes: d69d804 ("driver core: have match() callback in struct bus_type take a const *")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/20240710073413.495541-2-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gregkh committed Jul 10, 2024
1 parent 67c1ba5 commit c9add2e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions drivers/zorro/zorro-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ EXPORT_SYMBOL(zorro_unregister_driver);
* supported, and 0 if there is no match.
*/

static int zorro_bus_match(struct device *dev, struct device_driver *drv)
static int zorro_bus_match(struct device *dev, const struct device_driver *drv)
{
struct zorro_dev *z = to_zorro_dev(dev);
struct zorro_driver *zorro_drv = to_zorro_driver(drv);
const struct zorro_driver *zorro_drv = to_zorro_driver(drv);
const struct zorro_device_id *ids = zorro_drv->id_table;

if (!ids)
Expand Down
2 changes: 1 addition & 1 deletion include/linux/zorro.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ struct zorro_driver {
struct device_driver driver;
};

#define to_zorro_driver(drv) container_of(drv, struct zorro_driver, driver)
#define to_zorro_driver(drv) container_of_const(drv, struct zorro_driver, driver)


#define zorro_for_each_dev(dev) \
Expand Down

0 comments on commit c9add2e

Please sign in to comment.