Skip to content

Commit

Permalink
hwrng: rockchip - rst is used only during probe
Browse files Browse the repository at this point in the history
The driver uses the rst variable only for an initial reset when the chip
is probed. There's no need to store rst in the driver's private data, we
can make it a local variable in the probe function.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
martin-kaiser authored and herbertx committed Aug 30, 2024
1 parent 065c547 commit 9c27970
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions drivers/char/hw_random/rockchip-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
struct rk_rng {
struct hwrng rng;
void __iomem *base;
struct reset_control *rst;
int clk_num;
struct clk_bulk_data *clk_bulks;
};
Expand Down Expand Up @@ -132,6 +131,7 @@ static int rk_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
static int rk_rng_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct reset_control *rst;
struct rk_rng *rk_rng;
int ret;

Expand All @@ -148,14 +148,13 @@ static int rk_rng_probe(struct platform_device *pdev)
return dev_err_probe(dev, rk_rng->clk_num,
"Failed to get clks property\n");

rk_rng->rst = devm_reset_control_array_get_exclusive(&pdev->dev);
if (IS_ERR(rk_rng->rst))
return dev_err_probe(dev, PTR_ERR(rk_rng->rst),
"Failed to get reset property\n");
rst = devm_reset_control_array_get_exclusive(&pdev->dev);
if (IS_ERR(rst))
return dev_err_probe(dev, PTR_ERR(rst), "Failed to get reset property\n");

reset_control_assert(rk_rng->rst);
reset_control_assert(rst);
udelay(2);
reset_control_deassert(rk_rng->rst);
reset_control_deassert(rst);

platform_set_drvdata(pdev, rk_rng);

Expand Down

0 comments on commit 9c27970

Please sign in to comment.