Skip to content

Commit

Permalink
remoteproc: Make rproc_class constant
Browse files Browse the repository at this point in the history
Since commit 43a7206 ("driver core: class: make class_register() take
a const *"), the driver core allows for struct class to be in read-only
memory, so move the rproc_class structure to be declared at build time
placing it into read-only memory, instead of having to be dynamically
allocated at boot time.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Link: https://lore.kernel.org/r/20240305-class_cleanup-remoteproc2-v1-1-1b139e9828c9@marliere.net
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
  • Loading branch information
rbmarliere authored and mathieupoirier committed Mar 26, 2024
1 parent 4cece76 commit 1961511
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/remoteproc/remoteproc_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void rproc_init_debugfs(void);
void rproc_exit_debugfs(void);

/* from remoteproc_sysfs.c */
extern struct class rproc_class;
extern const struct class rproc_class;
int rproc_init_sysfs(void);
void rproc_exit_sysfs(void);

Expand Down
2 changes: 1 addition & 1 deletion drivers/remoteproc/remoteproc_sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ static const struct attribute_group *rproc_devgroups[] = {
NULL
};

struct class rproc_class = {
const struct class rproc_class = {
.name = "remoteproc",
.dev_groups = rproc_devgroups,
};
Expand Down

0 comments on commit 1961511

Please sign in to comment.