Skip to content

Commit

Permalink
netfilter: bitwise: improve error goto labels
Browse files Browse the repository at this point in the history
Replace two labels (`err1` and `err2`) with more informative ones.

Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: Florian Westphal <fw@strlen.de>
  • Loading branch information
a3a3el authored and Florian Westphal committed Apr 9, 2022
1 parent c70b921 commit 00bd435
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions net/netfilter/nft_bitwise.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,22 +109,23 @@ static int nft_bitwise_init_bool(struct nft_bitwise *priv,
return err;
if (mask.type != NFT_DATA_VALUE || mask.len != priv->len) {
err = -EINVAL;
goto err1;
goto err_mask_release;
}

err = nft_data_init(NULL, &priv->xor, sizeof(priv->xor), &xor,
tb[NFTA_BITWISE_XOR]);
if (err < 0)
goto err1;
goto err_mask_release;
if (xor.type != NFT_DATA_VALUE || xor.len != priv->len) {
err = -EINVAL;
goto err2;
goto err_xor_release;
}

return 0;
err2:

err_xor_release:
nft_data_release(&priv->xor, xor.type);
err1:
err_mask_release:
nft_data_release(&priv->mask, mask.type);
return err;
}
Expand Down

0 comments on commit 00bd435

Please sign in to comment.