Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call upstream if nothing found via friendly ID search #972

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

corwinstephen
Copy link

Prevent false positives when friendly ID doesn't match

@parndt
Copy link
Collaborator

parndt commented Jun 29, 2021

@corwinstephen thanks I added some suggestions; we can convert this from a guard clause to just use the result of exists_by_friendly_id? as that is what we're most interested in here.

@stale
Copy link

stale bot commented Oct 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 12, 2021
@parndt parndt added the pinned label Oct 12, 2021
@corwinstephen
Copy link
Author

Hey sorry to disappear on this. What are you thinking here? Looks like the specs had some trouble getting started.

@parndt
Copy link
Collaborator

parndt commented Oct 14, 2021

@corwinstephen it looks to me like there are 16 test failures and they're probably related to us expecting friendly_id to call super

@stale stale bot removed the stale label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants