Skip to content
This repository has been archived by the owner on Jul 18, 2019. It is now read-only.

NoFavicon bundle for Google Chrome #12

Closed
eklundchristopher opened this issue Dec 26, 2013 · 10 comments
Closed

NoFavicon bundle for Google Chrome #12

eklundchristopher opened this issue Dec 26, 2013 · 10 comments

Comments

@eklundchristopher
Copy link

Is there any possibility of adding support for the NoFavicon bundle developed by Michael Phines for the original SIMBL project?

The bundle removes the favicons in the bookmarks bar of Google Chrome. May not be a necessity for most, but god... I hate those favicons. The bundle works flawlessly through the original SIBML project, but for whatever reason, it doesn't do anything through EasySIMBL.

You may find the source code for the NoFavicon bundle over at Michael's github, https://github.com/michaelphines/NoFavicons

Appreciate your hard work & grateful for your response!
Cheers.

@norio-nomura
Copy link
Owner

Google Chrome has a "Bundle Blocker" mechanism which prevent loading unknown bundles.
The Bundle Blocker also have white list to allowing loading bundles.
Because the original SIMBL is in the white list, Google Chrome loads it.
http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/common/mac/cfbundle_blocker.mm?r1=101122&r2=105568

But, EasySIMBL is not in the white list, so Google Chrome does not load it.

@eklundchristopher
Copy link
Author

Ah... I see. This makes perfect sense, unfortunately...

Thank you for clarifying though! Are there any plans on getting onto their whitelist? Or would you reckon that is beyond your reach at this stage?

@norio-nomura
Copy link
Owner

I confirmed that Google Chrome v31.0.1650.63 load modified EasySIMBL.osax as following patch:

diff --git a/rez/Info.plist b/rez/Info.plist
index 481149e..dcd7ac7 100644
--- a/rez/Info.plist
+++ b/rez/Info.plist
@@ -7,7 +7,7 @@
    <key>CFBundleExecutable</key>
    <string>${EXECUTABLE_NAME}</string>
    <key>CFBundleIdentifier</key>
-   <string>com.github.norio-nomura.${PRODUCT_NAME:rfc1034identifier}.${WRAPPER_EXTENSION}</string>
+   <string>net.culater.SIMBL</string>
    <key>CFBundleInfoDictionaryVersion</key>
    <string>6.0</string>
    <key>CFBundleName</key>

But, I can't decide to apply this patch and release it.
I don't know about the policy of Google Chrome bundle blocker white list.

@Crazor
Copy link

Crazor commented Apr 15, 2014

Any news on this? I'd like to recommend EasySIMBL to my users because of the support for sandboxed applications. Since my plugin MenuBarHider injects itself into any Cocoa application, my users are affected by this as well. I'm currently linking to this thread to direct my users to this workaround.

norio-nomura added a commit that referenced this issue Aug 30, 2014
#12
Google Chrome has a "Bundle Blocker" mechanism which prevent loading unknown bundles.
The Bundle Blocker also have white list to allowing loading bundles.
Because the original SIMBL is in the white list, Google Chrome loads it.
http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/common/mac/cfbundle_blocker.mm?r1=101122&r2=105568
But, EasySIMBL is not in the white list, so Google Chrome does not load it.
@viveksjain
Copy link

Based on http://stackoverflow.com/a/7269797, I think it is OK to release the patch since EasySIMBL should play nicely with Chrome. If you're not sure you want to release it, could you at least create a download link for a compiled version of e0a89a3? (I tried to compile myself but don't have a developer ID, and no matter what I tried Xcode gives an error about signing identities.)

@norio-nomura
Copy link
Owner

I just released EasySIMBL-1.7 which contains e0a89a3.
But NoFavicon 1.2 has an issue on Google Chrome 39(64-bit). So I've tested it with Google Chrome 38.0.2125.122(32-bit)

@lpalpac
Copy link

lpalpac commented Nov 25, 2014

Hi Norio
Thanks a lot, you’re great !!

with the CFBundleIdentifier trick the 64 bit Chrome loads EasySIMBL right, but
NoFavicons Fails to load.

i get dload complaining about not finding symbols:

Symbol not found: OBJC_CLASS$_BookmarkBarFolderController
Symbol not found: OBJC_CLASS$_BookmarkButtonCell

Referenced from: /Users/lpalpac/Library/Application Support/SIMBL/Plugins/NoFavicons.bundle/Contents/MacOS/NoFavicons
Expected in: flat namespace
in /Users/lpalpac/Library/Application Support/SIMBL/Plugins/NoFavicons.bundle/Contents/MacOS/NoFavicons

i think its a problem similar to the one described here

http://stackoverflow.com/questions/3212901/symbol-not-found-objc-class-article

i tried changing some linking related compiling flags on Noavicons but with no luck.

i am not so deep in to objective c and xcode

the NofavIcons is a very small project i wonder if you cold get an eye on it
maybe you could find the issue with that

tried contacting NoFavicons developer but with noluck

Hope to hear from you

Thanks a lot

Luigi

Il giorno 25/nov/2014, alle ore 06:48, Norio Nomura notifications@github.com ha scritto:

I just released EasySIMBL-1.7 which contains e0a89a3.
But NoFavicon 1.2 has an issue on Google Chrome 39(64-bit). So I've tested it with Google Chrome 38.0.2125.122(32-bit)


Reply to this email directly or view it on GitHub.

@brentwcampbell
Copy link

I too have been using (and love) NoFavicons for a couple of years now and would love a fix for Chrome 39 (64bit). Please help all the haters of Favicons in the bookmark bar. :)

Let me know if I can be of any help.

@norio-nomura
Copy link
Owner

Hi @brentwcampbell,
I already have sent a pull request to NoFavicons for resolving that issue.

@norio-nomura
Copy link
Owner

NoFavicons 1.3 has been released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants