feat: Provide admin password to sidecar as hash #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admin password can and most likely should be provided to the container as a hash, instead of plaintext password. This commit adds a new environment variable 'XROAD_ADMIN_PWD_HASH', which can be used to supply a hash to sidecar container instead of hashing the plaintext password on container start. If 'XROAD_ADMIN_PWD_HASH' variable is not supplied, old behaviour is preserved.
|
Hello @tuomari! Thank you for the contribution, I have created a backlog item for our developers to review this contribution: https://nordic-institute.atlassian.net/browse/XRDDEV-2968. I see that you have already started the CLA process as well so the PR can be merged once it has been reviewed and the CLA approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin password can and most likely should be provided to the container as a hash, instead of plaintext password.
This commit adds a new environment variable 'XROAD_ADMIN_PWD_HASH', which can be used to supply a hash to sidecar container instead of hashing the plaintext password on container start. If 'XROAD_ADMIN_PWD_HASH' variable is not supplied, old behaviour is preserved.