Skip to content

Conversation

pau-dim
Copy link
Contributor

@pau-dim pau-dim commented May 28, 2025

No description provided.

@pau-dim pau-dim requested a review from raits May 28, 2025 07:49
@pau-dim pau-dim self-assigned this May 28, 2025
Copy link
Contributor

@raits raits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some blocks need revisiting, overall looks good.


For example, the following Central Server packages are currently installed.

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove bash from some of these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is, at first I only paid attention to remove the indented blocks. only afterwards I thought about correct format and changed the blocks again.

Error: The locale requested by the environment is invalid.
Error: could not create default cluster. Please create it manually with pg_createcluster 10 main –start,
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these error notification example blocks use bash. This one doesn't, we should decide on one approach or the other and then use it consistently.

If generation was successful the output should be simply:

```bash
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well, why remove bash?

Add the key id to `/etc/xroad/conf.d/local.ini` file (editing the file requires restarting X-Road services), e.g.:
```bash
```basinih
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing this should be ini?

* Network connections to PostgreSQL port (tcp/5432) are allowed from the Central Server to the remote database server.
1. Shutdown X-Road processes.
1. Shutdown X-Road processes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two spaces between the numbering and text seems strange, is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did so, because it was also done in other documents, like ug-sc_x-road_signer-console_user_guide.md:306
But its not done in this file, so I will make it 1.

ChallengeResponseAuthentication no
PasswordAuthentication no
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably more ini than bash.

[message-log]
archive-transfer-command=/usr/share/xroad/scripts/archive-http-transporter.sh -r http://my-archiving-server/cgi-bin/upload
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be ini.


[op-monitor-buffer]
size = 0
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be ini.

To edit the value of a system parameter already inserted into the *system_parameters* table:

UPDATE system_parameters SET value = '*parameter_value*', updated_at = (now() at time zone 'utc') WHERE key = 'parameter_name';
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a sql option, it would be more appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants