Implement the download_file widget action - #759
Merged
Conversation
🦋 Changeset detectedLatest commit: a1e0dea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
weeman1337
force-pushed
the
nic/feat/NEO-721-downlad-file-api
branch
from
August 26, 2024 09:21
354910f to
61ee791
Compare
HarHarLinks
requested changes
Aug 28, 2024
HarHarLinks
previously approved these changes
Aug 28, 2024
Contributor
|
test setup: matrix-org/matrix-widget-api#99 (comment) |
Contributor
|
matrix-widget-api was merged and released as 0.9.0, matrix-react-sdk was merged and is slated for the next element-web release cycle (RC on 2024-09-03 and release on 2024-09-10). |
HarHarLinks
marked this pull request as ready for review
August 30, 2024 15:16
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
HarHarLinks
force-pushed
the
nic/feat/NEO-721-downlad-file-api
branch
from
August 30, 2024 15:17
d3462dd to
d325f55
Compare
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
Contributor
|
one missing part appears |
Signed-off-by: Milton Moura <miltonmoura@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Implements usage of the
download_fileaction of the Widget API.See MSC4039 .
Also moves the
UploadImagePagepage toImagePagesince it now demos up- and download of content.Needs matrix-org/matrix-react-sdk#12931
✔️ Checklist
Signed-off-byline in the message (more info).