Skip to content

Implement the download_file widget action - #759

Merged
HarHarLinks merged 4 commits into
mainfrom
nic/feat/NEO-721-downlad-file-api
Sep 4, 2024
Merged

Implement the download_file widget action#759
HarHarLinks merged 4 commits into
mainfrom
nic/feat/NEO-721-downlad-file-api

Conversation

@weeman1337

@weeman1337 weeman1337 commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Implements usage of the download_file action of the Widget API.
See MSC4039 .

Also moves the UploadImagePage page to ImagePage since it now demos up- and download of content.

Needs matrix-org/matrix-react-sdk#12931

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

@changeset-bot

changeset-bot Bot commented Aug 26, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a1e0dea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@matrix-widget-toolkit/api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HarHarLinks HarHarLinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is wrong, the upload happens 3 times every time i try it:
image

HarHarLinks
HarHarLinks previously approved these changes Aug 28, 2024
@HarHarLinks

Copy link
Copy Markdown
Contributor

test setup: matrix-org/matrix-widget-api#99 (comment)

@HarHarLinks

Copy link
Copy Markdown
Contributor

matrix-widget-api was merged and released as 0.9.0, matrix-react-sdk was merged and is slated for the next element-web release cycle (RC on 2024-09-03 and release on 2024-09-10).

@HarHarLinks
HarHarLinks marked this pull request as ready for review August 30, 2024 15:16
@HarHarLinks
HarHarLinks requested a review from a team August 30, 2024 15:16
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
@HarHarLinks
HarHarLinks force-pushed the nic/feat/NEO-721-downlad-file-api branch from d3462dd to d325f55 Compare August 30, 2024 15:17
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks

Copy link
Copy Markdown
Contributor

one missing part appears

diff --git a/example-widget-mui/src/ImagePage/ImagePage.test.tsx b/example-widget-mui/src/ImagePage/ImagePage.test.tsx
index 69233d9..9842b7a 100644
--- a/example-widget-mui/src/ImagePage/ImagePage.test.tsx
+++ b/example-widget-mui/src/ImagePage/ImagePage.test.tsx
@@ -95,6 +95,7 @@ describe('<ImagePage>', () => {
         ROOM_EVENT_UPLOADED_IMAGE,
       ),
       WidgetApiFromWidgetAction.MSC4039UploadFileAction,
+      WidgetApiFromWidgetAction.MSC4039DownloadFileAction,
       WidgetApiFromWidgetAction.MSC4039GetMediaConfigAction,
     ]);

Signed-off-by: Milton Moura <miltonmoura@gmail.com>

@mgcm mgcm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@HarHarLinks
HarHarLinks merged commit 9852f94 into main Sep 4, 2024
@HarHarLinks
HarHarLinks deleted the nic/feat/NEO-721-downlad-file-api branch September 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants