Skip to content

Commit

Permalink
build: use bootstrap --ci and recreate all package-lock.json files (a…
Browse files Browse the repository at this point in the history
…ws#1681)

In order to improve the reliability of our builds, the `--ci` flag will tell lerna to use "npm ci" instead of "npm install" which enforces that package-lock files exist for all modules.

Also, remove "--no-package-lock" from lerna.json.

Fixes aws#1405
  • Loading branch information
Elad Ben-Israel authored Feb 5, 2019
1 parent 8e03ed6 commit 3842a9d
Show file tree
Hide file tree
Showing 98 changed files with 20,407 additions and 181,524 deletions.
5 changes: 0 additions & 5 deletions examples/cdk-examples-java/package-lock.json

This file was deleted.

5 changes: 0 additions & 5 deletions examples/cdk-examples-typescript/package-lock.json

This file was deleted.

8 changes: 6 additions & 2 deletions install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,18 @@ set -euo pipefail

export NODE_OPTIONS="--max-old-space-size=4096 ${NODE_OPTIONS:-}"

if ! npm ci --help; then
echo "upgrading npm, because "npm ci" is not supported"
npm i -g npm
fi

echo "============================================================================================="
echo "installing repo-global dependencies..."
npm i --no-package-lock --global-style
npm ci --global-style

# Now that we have lerna available...
export PATH=node_modules/.bin:$PATH

echo "============================================================================================="
echo "bootstrapping..."
lerna bootstrap --reject-cycles
lerna bootstrap --reject-cycles --ci
7 changes: 0 additions & 7 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@
"packages/@aws-cdk/*",
"tools/*"
],
"command": {
"bootstrap": {
"npmClientArgs": [
"--no-package-lock"
]
}
},
"rejectCycles": "true",
"version": "0.23.0"
}
Loading

0 comments on commit 3842a9d

Please sign in to comment.