Skip to content

Commit

Permalink
Export few data types from content-recommendation.js (ampproject#20854)
Browse files Browse the repository at this point in the history
It allows users of that file to use the types. Given that we return objects of these types from exported functions - exporting types themselves makes sense.

Tested:
  presubmit
  • Loading branch information
nbeloglazov authored and Noran Azmy committed Mar 22, 2019
1 parent 9dd1c47 commit 09e635d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ads/google/a4a/shared/content-recommendation.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ const PUB_CONTROL_EXAMPLE = '\n ' +
* will be used in ad request.
* @record
*/
class CoReConfig { // eslint-disable-line no-unused-vars
export class CoReConfig { // eslint-disable-line no-unused-vars
/** see comment on class */
constructor() {
/** @const {number} */
Expand Down Expand Up @@ -236,13 +236,13 @@ export function getAutoConfig(availableWidth, isMobile) {
* layoutType: (string|undefined),
* }}
*/
let RawPublisherControlParams; // eslint-disable-line no-unused-vars
export let RawPublisherControlParams; // eslint-disable-line no-unused-vars

/**
* Get CoRe Pub Control UI Sizes.
* @param {number} availableWidth
* @param {!RawPublisherControlParams} rawPubControlParams
* @return {?CoReConfig}
* @return {!CoReConfig}
*/
export function getPubControlConfig(availableWidth, rawPubControlParams) {
const pubParams = validateAndParsePubControlParams(rawPubControlParams);
Expand Down

0 comments on commit 09e635d

Please sign in to comment.