Add the missing bind for assert #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-martin
added a commit
that referenced
this pull request
Mar 1, 2015
Add the missing bind for assert
doug-martin
added a commit
to doug-martin/nools
that referenced
this pull request
Mar 2, 2015
* Fixed issue with `CustomConstraint` not binding `this.assert` to `this`. noolsjs#146 - @raymondfeng * Added more tests for custom constraints * Updated readme to include docs about custom constraints.
Merged
|
Thanks Raymond. I added some tests to ensure we don't have any regressions on this and added some docs. Feel free to add some more docs if you can think of better examples. Thanks again! -Doug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@doug-martin The previous PR is missing a
bindto ensureasserthas the correct receiver.