NS-CACHE: Support S3 operations for cache enabled buckets #6130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptsanj
force-pushed
the
sgupta/s3-operations
branch
from
8972228
to
7ca3ae8
Compare
guymguym
changed the title
guptsanj
force-pushed
the
sgupta/s3-operations
branch
3 times, most recently
from
c4f0785
to
dff4429
Compare
guptsanj
force-pushed
the
sgupta/s3-operations
branch
from
dff4429
to
7138a38
Compare
jeniawhite
previously requested changes
Aug 24, 2020
guymguym
reviewed
Aug 24, 2020
guymguym
reviewed
Aug 24, 2020
guptsanj
force-pushed
the
sgupta/s3-operations
branch
from
7138a38
to
684f4e6
Compare
guymguym
requested changes
Aug 25, 2020
guptsanj
force-pushed
the
sgupta/s3-operations
branch
from
684f4e6
to
1bf1280
Compare
guymguym
reviewed
Aug 25, 2020
guymguym
reviewed
Aug 25, 2020
guymguym
reviewed
Aug 25, 2020
guptsanj
force-pushed
the
sgupta/s3-operations
branch
from
1bf1280
to
bd54d21
Compare
guymguym
reviewed
Aug 25, 2020
guymguym
reviewed
Aug 25, 2020
guymguym
reviewed
Aug 25, 2020
guptsanj
force-pushed
the
sgupta/s3-operations
branch
from
bd54d21
to
ed289d4
Compare
guymguym
reviewed
Aug 25, 2020
guymguym
reviewed
Aug 25, 2020
guptsanj
force-pushed
the
sgupta/s3-operations
branch
from
ed289d4
to
c87d32a
Compare
2. Server Side copy for a cache miss for a source bucket different than the target bucket 3. Multipart upload copy from a same/different sources 4. List objects from cache/hub 5. List Object versions defaults to List objects for cache enabled buckets 6. List multipart uploads from hub 7. Handle add/remove/get object tags from cache/hub buckets 8. Store last modified time from hub for cached objects. Return this value as the last modified time with cached objects. 9. Update Unit test Signed-off-by: Sanjeev Gupta <guptsanj@us.ibm.com>
guptsanj
force-pushed
the
sgupta/s3-operations
branch
from
c87d32a
to
e9b614e
Compare
guymguym
dismissed
jeniawhite’s stale review
not relevant in latest code. thanks @jenia!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Update Unit test
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: