Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of md5 calculation on get_blob blobs below 4mb and md5 header fixes #4716

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

jeniawhite
Copy link
Contributor

@jeniawhite jeniawhite commented Apr 22, 2018

Explain the changes:

Issues: Fixed / Gap #xxx

Testing Instructions:

Reminders:

  • Create a new test - the first is the hardest
  • User Experience is top priority
  • Design for failure
  • Keep it simple
  • npm test
  • Imagine a support call - Add diagnostics info, phonehome info, activity log events, external syslog
  • Upgrade - DB schema, server platform, agents install, npm packages

@jeniawhite jeniawhite force-pushed the evgb-FixingGetBlobHeaders branch 2 times, most recently from f1ab469 to 877c11c Compare April 23, 2018 14:20
Copy link
Member

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new unit test for blob like test_s3_ops.js and put some first tests there.

@nimrod-becker
Copy link
Contributor

@guymguym we are going to tackle the block list ops as well, lets add testing of blob API to that effort, I want Jenia to be able to quickly get back to versions

@guymguym
Copy link
Member

@nimrod-becker Your call. I would still push the first test now since we have no automated validation for blob which means that even if all checks are passing we have no idea if this PR works or breaks our blob service.

@jeniawhite jeniawhite merged commit 6d173b3 into master Apr 24, 2018
@jeniawhite jeniawhite deleted the evgb-FixingGetBlobHeaders branch May 15, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants