Fix r-value ref miscompile on MSVC v19.22.#41
Merged
Conversation
Collaborator
|
Thanks for your PR. The comma expression is/was used for C++11 constexpr-ness. Correctness comes first naturally. Have to think a bit what approach I'd like. |
Contributor
Author
|
That's what I get for not checking clang warnings. Since l-value refs aren't affected, the simplest solution is to just rearrange the expression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning an r-value reference through the comma operator is miscompiled by MSVC v19.22, as evidenced here.
Examples of tests failures without the
expected.hppchanges on MSVC v19.16: