chore: Fix typo and a few maintenance stuff (bxcodec#15)

* fix typo
* change logic in usecase to get author details
* fix some test and change code styling

Gopkg.toml

@@ -60,3 +60,7 @@
 [prune]
   go-tests = true
   unused-packages = true
+
+[[constraint]]
+  branch = "master"
+  name = "golang.org/x/sync"

article/delivery/http/article_handler.go

@@ -7,19 +7,33 @@ import (
 
 	"github.com/sirupsen/logrus"
 
-	models "github.com/bxcodec/go-clean-arch/models"
+	"github.com/bxcodec/go-clean-arch/models"
 
-	articleUcase "github.com/bxcodec/go-clean-arch/article"
+	"github.com/bxcodec/go-clean-arch/article"
 	"github.com/labstack/echo"
 
 	validator "gopkg.in/go-playground/validator.v9"
 )
 
+// ResponseError represent the reseponse error struct
 type ResponseError struct {
 	Message string `json:"message"`
 }
+
+// HttpArticleHandler  represent the httphandler for article
 type HttpArticleHandler struct {
-	AUsecase articleUcase.ArticleUsecase
+	AUsecase article.Usecase
+}
+
+func NewArticleHttpHandler(e *echo.Echo, us article.Usecase) {
+	handler := &HttpArticleHandler{
+		AUsecase: us,
+	}
+	e.GET("/articles", handler.FetchArticle)
+	e.POST("/articles", handler.Store)
+	e.GET("/articles/:id", handler.GetByID)
+	e.DELETE("/articles/:id", handler.Delete)
+
 }
 
 func (a *HttpArticleHandler) FetchArticle(c echo.Context) error {
@@ -84,13 +98,14 @@ func (a *HttpArticleHandler) Store(c echo.Context) error {
 		ctx = context.Background()
 	}
 
-	ar, err := a.AUsecase.Store(ctx, &article)
+	err = a.AUsecase.Store(ctx, &article)
 
 	if err != nil {
 		return c.JSON(getStatusCode(err), ResponseError{Message: err.Error()})
 	}
-	return c.JSON(http.StatusCreated, ar)
+	return c.JSON(http.StatusCreated, article)
 }
+
 func (a *HttpArticleHandler) Delete(c echo.Context) error {
 	idP, err := strconv.Atoi(c.Param("id"))
 	id := int64(idP)
@@ -99,10 +114,9 @@ func (a *HttpArticleHandler) Delete(c echo.Context) error {
 		ctx = context.Background()
 	}
 
-	_, err = a.AUsecase.Delete(ctx, id)
+	err = a.AUsecase.Delete(ctx, id)
 
 	if err != nil {
-
 		return c.JSON(getStatusCode(err), ResponseError{Message: err.Error()})
 	}
 	return c.NoContent(http.StatusNoContent)
@@ -113,28 +127,15 @@ func getStatusCode(err error) int {
 	if err == nil {
 		return http.StatusOK
 	}
-
 	logrus.Error(err)
 	switch err {
-	case models.INTERNAL_SERVER_ERROR:
-
+	case models.ErrInternalServerError:
 		return http.StatusInternalServerError
-	case models.NOT_FOUND_ERROR:
+	case models.ErrNotFound:
 		return http.StatusNotFound
-	case models.CONFLICT_ERROR:
+	case models.ErrConflict:
 		return http.StatusConflict
 	default:
 		return http.StatusInternalServerError
 	}
 }
-
-func NewArticleHttpHandler(e *echo.Echo, us articleUcase.ArticleUsecase) {
-	handler := &HttpArticleHandler{
-		AUsecase: us,
-	}
-	e.GET("/article", handler.FetchArticle)
-	e.POST("/article", handler.Store)
-	e.GET("/article/:id", handler.GetByID)
-	e.DELETE("/article/:id", handler.Delete)
-
-}

article/delivery/http/article_test.go

@@ -11,7 +11,7 @@ import (
 
 	articleHttp "github.com/bxcodec/go-clean-arch/article/delivery/http"
 	"github.com/bxcodec/go-clean-arch/article/mocks"
-	models "github.com/bxcodec/go-clean-arch/models"
+	"github.com/bxcodec/go-clean-arch/models"
 	"github.com/labstack/echo"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
@@ -23,7 +23,7 @@ func TestFetch(t *testing.T) {
 	var mockArticle models.Article
 	err := faker.FakeData(&mockArticle)
 	assert.NoError(t, err)
-	mockUCase := new(mocks.ArticleUsecase)
+	mockUCase := new(mocks.Usecase)
 	mockListArticle := make([]*models.Article, 0)
 	mockListArticle = append(mockListArticle, &mockArticle)
 	num := 1
@@ -49,10 +49,10 @@ func TestFetch(t *testing.T) {
 }
 
 func TestFetchError(t *testing.T) {
-	mockUCase := new(mocks.ArticleUsecase)
+	mockUCase := new(mocks.Usecase)
 	num := 1
 	cursor := "2"
-	mockUCase.On("Fetch", mock.Anything, cursor, int64(num)).Return(nil, "", models.INTERNAL_SERVER_ERROR)
+	mockUCase.On("Fetch", mock.Anything, cursor, int64(num)).Return(nil, "", models.ErrInternalServerError)
 
 	e := echo.New()
 	req, err := http.NewRequest(echo.GET, "/article?num=1&cursor="+cursor, strings.NewReader(""))
@@ -77,7 +77,7 @@ func TestGetByID(t *testing.T) {
 	err := faker.FakeData(&mockArticle)
 	assert.NoError(t, err)
 
-	mockUCase := new(mocks.ArticleUsecase)
+	mockUCase := new(mocks.Usecase)
 
 	num := int(mockArticle.ID)
 
@@ -111,12 +111,12 @@ func TestStore(t *testing.T) {
 
 	tempMockArticle := mockArticle
 	tempMockArticle.ID = 0
-	mockUCase := new(mocks.ArticleUsecase)
+	mockUCase := new(mocks.Usecase)
 
 	j, err := json.Marshal(tempMockArticle)
 	assert.NoError(t, err)
 
-	mockUCase.On("Store", mock.Anything, mock.AnythingOfType("*models.Article")).Return(&mockArticle, nil)
+	mockUCase.On("Store", mock.Anything, mock.AnythingOfType("*models.Article")).Return(nil)
 
 	e := echo.New()
 	req, err := http.NewRequest(echo.POST, "/article", strings.NewReader(string(j)))
@@ -141,11 +141,11 @@ func TestDelete(t *testing.T) {
 	err := faker.FakeData(&mockArticle)
 	assert.NoError(t, err)
 
-	mockUCase := new(mocks.ArticleUsecase)
+	mockUCase := new(mocks.Usecase)
 
 	num := int(mockArticle.ID)
 
-	mockUCase.On("Delete", mock.Anything, int64(num)).Return(true, nil)
+	mockUCase.On("Delete", mock.Anything, int64(num)).Return(nil)
 
 	e := echo.New()
 	req, err := http.NewRequest(echo.DELETE, "/article/"+strconv.Itoa(int(num)), strings.NewReader(""))