[525] mempool 주소 가져오는 로직 리팩토링 #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(block_explorer_screen 수정 과정에서 block_explorer_view_model 생성)
2 tasks
roy-noncelab
changed the title
roy-noncelab
changed the title
| } | ||
| } | ||
|
|
||
| if (serverName == 'CUSTOM') { |
Collaborator
There was a problem hiding this comment.
이왕 리팩토링하는거 const나 enum으로 정의해서 비교하면 안전할 것 같네요.
|
|
||
| if (serverName.isEmpty) { | ||
| if (NetworkType.currentNetworkType == NetworkType.mainnet) { | ||
| setDefaultElectrumServer(DefaultElectrumServer.coconut); |
Collaborator
There was a problem hiding this comment.
getter 내부에서 async setter 호출하고 있네요. provider 생성 시 초기화하고, getter에서는 초기화 여부만 확인해서 (ensure 메서드 등으로 분리) getter 역할만 하는게 좋겠습니다.
| } | ||
|
|
||
| Future<void> setCustomExplorerUrl(String url) async { | ||
| var formattedUrl = url.trim(); |
Collaborator
There was a problem hiding this comment.
block_explorer_view_model.dart에도 중복 코드가 있으니 url normalize 유틸로 빼면 좋을 것 같습니다.
…to refactor/525-mempool
Collaborator
|
transaction_Detail_screen, utxo_Detail_screen.dart 파일에 에러 있음. |
Collaborator
ella-noncelab
left a comment
ella-noncelab
left a comment
There was a problem hiding this comment.
develop 브랜치 머지했습니다.
|
|
||
| NetworkPreferenceProvider(); | ||
|
|
||
| Future<void> ensureInitialized() async { |
Collaborator
|
😭 아무래도 Electrum 설정 provider와 blockExplorer 설정 provider를 분리해야할 것 같아요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue : #525
block_explorer_service.dart의 getExplorerUrl이 화면 진입 마다 viewmodel에 의해 작동되어 비효율적인 상황
변경 사항
lib/providers/preference_provider.dart에서 네트워크 관련 부분 network_preference_provider.dart로 분리
block_explorer_service.dart 파일 삭제 후 network_preference_provider.dart로 로직 통합.
해당 과정에서 사용되는 변수 및 함수가 있는 연관된 viewmodel, screen 파일도 같이 수정.
특이 사항
preference_provider 추가로 분리하는 리팩토링 필요