-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support both JS/JVM and 2.10/2.11 via unmanagedSourceDirectories #2
Comments
Why or in what way is the new version less powerful? I'm fairly new to macros and looking at the two signatures, I don't understand the difference. |
Also, if you haven't read the following link, I think it would be helpful wrt this issue: http://www.scala-js.org/api/sbt-scalajs/0.6.4/#org.scalajs.sbtplugin.cross.CrossProject |
@japgolly My understanding is that with the current macro if you "summon" an This additional specificity isn't something that I need in most cases but my understanding is that libraries like Shapeless do really benefit from it. |
Trying to cross build 2.10 and 2.11 here may also run aground on https://github.com/InTheNow/sbt-scalajs/issues/19 now that we are publishing for scala.js too. |
Also, discipline is not released, despite typelevel/discipline#13 |
Now that macro-compat is out, would you be looking to support the 2.11 more powerful and 2.10 less powerful at the same time? I'm asking because I'm very interested in seeing what this project could do for things we're working on at work. |
While adding scala.js support, I was forced to remove the
src/main/scala_2.10
andsrc/main/scala_2.11
directories. Previously we used:This didn't work with scala.js, so I was forced to write macros that worked in both 2.10 and 2.11. However, this makes the macros under 2.11 slightly less powerful.
Old code (more powerful):
New code (2.10 compatible):
The text was updated successfully, but these errors were encountered: