Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add openai-compatible api models #2683

Merged
merged 22 commits into from
Jul 25, 2024
Merged

feat: add openai-compatible api models #2683

merged 22 commits into from
Jul 25, 2024

Conversation

supersonictw
Copy link
Contributor

@supersonictw supersonictw commented Jul 17, 2024 •
edited
Loading

Describe your changes

The feature of connecting to OpenAI compatible server for chatting.

Issue ticket number and link

#1243

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Explore Models
Installed Models
Chats
Network Errors
Toast Notifications

Steps to Reproduce

None

Notes

TODO:

  • Check the base URL is valid
  • Display the installed server info on the model list

@supersonictw supersonictw changed the title feat: add openai-compatible for chat draft: add openai-compatible for chat Jul 17, 2024
@supersonictw supersonictw marked this pull request as draft July 17, 2024 08:56
@supersonictw
feat: add openai-compatible for chat
e05645c 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@manyoso
Copy link
Collaborator

manyoso commented Jul 17, 2024 •
edited
Loading

I like it... @cebtenzzre you?

Biggest problem I see is that the UI needs to be reworked so that people could install more than one of these and also it should be marked somehow that it is remote/network model more prominently

@manyoso manyoso requested a review from cebtenzzre July 17, 2024 13:37
@supersonictw
feat: check base url is valid or not
b363206 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
feat: multiple api-compatible models
1bb37bb 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
feat: display info of api-compatible models
792c12e 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
feat: add name for api-compatible models
7fc2641 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
feat: make api-compatible models ux better
f460255 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
fix(gpt4all-chat/chatapi.cpp): comment out debug
440fc2f 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
feat: make model views ux better
543f45c 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
feat: make model views ux better
3d99617 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
fix: replace raw capi prefix with hash due to max filename length
054732c 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
feat: make model views ux better
3aa40f8 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
fix(gpt4all-chat/qml/ChatView.qml): default model name
1103535 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw supersonictw changed the title draft: add openai-compatible for chat Add openai-compatible for chat Jul 18, 2024
@supersonictw supersonictw changed the title Add openai-compatible for chat feat: add openai-compatible for chat Jul 18, 2024
@supersonictw supersonictw changed the title feat: add openai-compatible for chat feat: add openai-compatible api models Jul 18, 2024
@supersonictw
fix: model id is same as model filename
5ea59fc 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
fix(chatapi.cpp): not all responses will be valid
c47bd88 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
refactor: make error message prefix upper
810ce36 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw supersonictw marked this pull request as ready for review July 19, 2024 08:23
@supersonictw
docs(modellist.h): add comments
b177b90 
For explaining what are differences between 'isOnline' and 'isCompatibleApi' in ModelInfo.

Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
docs(modellist.h): correct typos of comments
5ce89e3 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
docs: add comments for the source of toast
c9b4222 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@ThiloteE ThiloteE mentioned this pull request Jul 19, 2024
Open
cebtenzzre and others added 4 commits July 19, 2024 17:28
@cebtenzzre
Toast: make license unambiguous
9afb6b1 
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
@supersonictw
fix: api-compatible model isn't removed from memory when it removed
c15729b 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
fix(chatapi.cpp): error message isn't showing when reply is empty
e96804e 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@supersonictw
docs(modellist.cpp): add comments
d928595 
Signed-off-by: Shiranui <supersonic@livemail.tw>
@manyoso manyoso merged commit f9cd2e3 into nomic-ai:main Jul 25, 2024
2 checks passed
@cosmic-snow cosmic-snow mentioned this pull request Jul 29, 2024
Open
@supersonictw supersonictw deleted the openai_compatible branch July 31, 2024 03:55
@cebtenzzre cebtenzzre mentioned this pull request Aug 4, 2024
Closed
This was referenced Aug 12, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre left review comments

@manyoso manyoso manyoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supersonictw @manyoso @cebtenzzre