Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 9.10.1 support #78

Merged
merged 1 commit into from
Jul 8, 2024
Merged

GHC 9.10.1 support #78

merged 1 commit into from
Jul 8, 2024

Conversation

andrevdm
Copy link
Contributor

@andrevdm andrevdm commented Jul 8, 2024

No description provided.

@nomeata
Copy link
Owner

nomeata commented Jul 8, 2024

Thanks! No source changes needed? Then I’ll just update the metadata via a hackage revision.

@andrevdm
Copy link
Contributor Author

andrevdm commented Jul 8, 2024

It compiles and test pass locally :) I PRed though to see if CI passes (and it does)
Would be great as a metadata update though, so I'll close this

Thanks!

@andrevdm andrevdm closed this Jul 8, 2024
@nomeata
Copy link
Owner

nomeata commented Jul 8, 2024

I’d still like to have it in the repo for the next release, sorry for the confusion!

@nomeata nomeata reopened this Jul 8, 2024
@nomeata nomeata merged commit 84cb503 into nomeata:master Jul 8, 2024
24 checks passed
@Bodigrim
Copy link
Contributor

Bodigrim commented Jul 8, 2024

@nomeata @andrevdm are you sure about this? inspection-testing worked fine with GHC 9.10, which corresponds to base-4.20. This PR allows building against base-4.21, presumably to be a part of future GHC 9.12. Isn't it too early? If anything, it does not make terribly much sense to relax base but keep build-depends: ghc < 9.11.

@andrevdm
Copy link
Contributor Author

andrevdm commented Jul 9, 2024

Wow, no, I seem to have got something wrong there then. I was pretty sure it was not compiling for 9.10 for me but those bounds make no sense... Let me check again and submit a fix, sorry for the confusion.

@andrevdm andrevdm mentioned this pull request Jul 9, 2024
@andrevdm
Copy link
Contributor Author

andrevdm commented Jul 9, 2024

#79 submitted. Sorry for that and thanks @Bodigrim for taking the time to check that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants