Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes to a variety of problems.
First off, building on a current Linux system, there are many linking errors of the type "multiple definitions".
As one example, the variable
float note_diff
is defined in multiple sources, without the static keyword, although the use of this variable is file-local.I went through the global variables and applied the fixes as I found appropriate.
Moreover, I've tagged global variables with a tag
GLOBAL_STATE
, if this is OK.It's in order to help future efforts of porting Bristol to plugins, where the global state is a problem and it must be eventually rewritten in a more appropriate manner.
Also,
const
keywords where possible, fixes of bash errors, etc.