Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #22

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Various fixes #22

wants to merge 6 commits into from

Conversation

jpcima
Copy link

@jpcima jpcima commented May 8, 2021

This PR contains fixes to a variety of problems.

First off, building on a current Linux system, there are many linking errors of the type "multiple definitions".
As one example, the variable float note_diff is defined in multiple sources, without the static keyword, although the use of this variable is file-local.

I went through the global variables and applied the fixes as I found appropriate.

Moreover, I've tagged global variables with a tag GLOBAL_STATE, if this is OK.
It's in order to help future efforts of porting Bristol to plugins, where the global state is a problem and it must be eventually rewritten in a more appropriate manner.

Also, const keywords where possible, fixes of bash errors, etc.

@jpcima jpcima mentioned this pull request May 8, 2021
@hfiguiere
Copy link

to fix the problem with globals, I just added this to the configure.ac after AC_SUBST(BRISTOL_HAS_OSS)

# Newer gcc require this to build
CFLAGS="$CFLAGS -fcommon"

-fno-common has become default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants