Skip to content

feat(git-changelog): display commit authors inside line with avatars #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nekomeowww merged 4 commits into from
Jul 22, 2024
Merged

feat(git-changelog): display commit authors inside line with avatars #275

nekomeowww merged 4 commits into from
Jul 22, 2024

Conversation

@lulu0119
Copy link
Contributor

@lulu0119 lulu0119 commented Jul 21, 2024 •
edited by nekomeowww
Loading

Close #258

nekomeowww
nekomeowww previously approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions
Copy link

github-actions bot commented Jul 21, 2024 •
edited
Loading

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://669dc82ebbeee5d3040ba424--nolebase-integrations.netlify.app
Windows Success https://669dc839cddb9b96759bdd29--nolebase-integrations.netlify.app

northword
northword reviewed Jul 21, 2024
View reviewed changes
@nekomeowww nekomeowww dismissed their stale review July 21, 2024 13:17

Test failed

@northword northword mentioned this pull request Jul 21, 2024
Merged
northword and others added 2 commits July 21, 2024 22:16
@northword
fix: tweaks
c8aff08
@lulu0119
Merge pull request #1 from northword/fix/pr-lulu0119-275
564d074 
fix: revert Commit interface and get authors for commit on client
@nekomeowww nekomeowww requested a review from northword July 22, 2024 02:36
@nekomeowww nekomeowww added enhancement New feature or request pkg/git-changelog Related to @nolebase/vitepress-plugin-git-changelog difficulty/medium Medium level to deal with / implement against documentation Improvements or additions to documentation labels Jul 22, 2024
@nekomeowww nekomeowww merged commit a82943e into nolebase:main Jul 22, 2024
@lulu0119
Copy link
Contributor Author

lulu0119 commented Jul 22, 2024

@northword I truly appreciate you taking the time to review and correct the problems in the code. My apologies for not getting back to you sooner; I was utterly exhausted last night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nekomeowww nekomeowww nekomeowww approved these changes

@northword northword northword approved these changes

Assignees

No one assigned

Labels

difficulty/medium Medium level to deal with / implement against documentation Improvements or additions to documentation enhancement New feature or request pkg/git-changelog Related to @nolebase/vitepress-plugin-git-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature request: new optional component to display authors of commits right inside of commit line

3 participants

@lulu0119 @nekomeowww @northword