Allow setting controller block owner deletion false

[nashant]

What do these changes do?

This will allow setting controller and blockOwnerDeletion from both build_owner_references and append_owner_references

Description

Previous behaviour:
Error from trying to set multiple owner controllers

New behaviour:
Allow explicitly setting controller=False, so no error

Does the change affect end users?
Only if they choose to use it

Issues/PRs

Related:
#687

Type of changes

• New feature (non-breaking change which adds functionality)

Checklist

• The code addresses only the mentioned problem, and this problem only
• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt

[nolar]

Would it also make sense to add these same-named arguments to kopf.adopt() — an aggregate on top of all these ownership/hierarchy functions? For consistency of the interfaces. Wdyt?

[nolar]

Please rebase on main and force-push — #859 has fixed the tests.

[nashant]

Would it also make sense to add these same-named arguments to kopf.adopt() — an aggregate on top of all these ownership/hierarchy functions? For consistency of the interfaces. Wdyt?

I considered that and decided probably not. As per the comment you left on the issue I referenced I think adopt means that the child is under full control of the parent. If I'm adding an owner ref explicitly then I may well want to have multiple, if I'm adopting then I want that as the only owner

[nashant]

I've rebased against main but am still getting the tests/hierarchies/test_labelling.py failures

[nashant]

Ok, I've re-rebased against your main (forgot I had accidentally pushed to my main) and commits are now clean, but still the same test failures

[nashant]

Would it also make sense to add these same-named arguments to kopf.adopt() — an aggregate on top of all these ownership/hierarchy functions? For consistency of the interfaces. Wdyt?

I considered that and decided probably not. As per the comment you left on the issue I referenced I think adopt means that the child is under full control of the parent. If I'm adding an owner ref explicitly then I may well want to have multiple, if I'm adopting then I want that as the only owner

@nolar what would you prefer?