Improve icon readability in light theme #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickColley
added this to the Meet Web Content Accessibility Guidelines 2.1 level AA milestone
Boost contrast of the default colour theme, to be closer to the other theme's saturation then boost the unpressed state for action buttons. This brings the icons to 3:1 contrast while keeping colour in themes.
NickColley
force-pushed
the
improve-default-theme-icon-unpressed-state
branch
from
7266184 to
86173ed
Compare
NickColley
changed the title
nolanlawson
reviewed
Dec 18, 2022
nolanlawson
requested changes
Dec 18, 2022
|
Niceee 👍 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nolanlawson
approved these changes
Dec 18, 2022
alice-werefox
pushed a commit
to alice-werefox/sema-werefox-cafe
that referenced
this pull request
Apr 3, 2023
Boost contrast of the default colour theme, to be closer to the other theme's saturation then boost the unpressed state for action buttons. This brings the icons to 3:1 contrast while keeping colour in themes. Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the contrast of unpressed action buttons so they're easier to see.
This brings the icons to 3:1 contrast while keeping colour in themes.
Before
After