feat: Make it possible to close inline reply with the escape key. #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsteh
commented
Nov 28, 2022
| this.reply() | ||
| try { | ||
| // return focus to the article. | ||
| this.refs.node.closest('article').focus({ preventScroll: true }) |
There was a problem hiding this comment.
- There's some probably not great coupling here, but I'm not sure how else to get at the article.
- This is potentially controversial. I think most users who value this will be using keyboard shortcuts, in which case focusing the article makes sense, since they probably opened the reply by focusing the article and pressing r. On the other hand, a decision was made to focus the Reply button after a reply is posted. Personally, I think the article should be focused in that case too, but I can understand the other perspective here too; the reply may well have been opened by tabbing to the reply button and pressing it.
There was a problem hiding this comment.
There's some probably not great coupling here, but I'm not sure how else to get at the article.
One common way to do this in Svelte is to fire an event and have the parent handle it. I can refactor to do that.
I don't think this is super controversial. I'm not sure what else Esc could be used for. Also, it is possible to disable keyboard shortcuts entirely.
BTW I also have a utility called tryToFocusElement that does the try/catch.
nolanlawson
approved these changes
Dec 2, 2022
alice-werefox
pushed a commit
to alice-werefox/sema-werefox-cafe
that referenced
this pull request
Apr 3, 2023
…lanlawson#2273) Fixes nolanlawson#915. Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #915.