Bearer only client #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lodrantl, could you rebase the PR from the current master? There was a problem with CI, which is fixed now. |
Pull Request Test Coverage Report for Build 63
💛 - Coveralls |
|
Finnally took the time to rebase and add the tests. Also deployed it to staging env and we'll see how it goes. |
|
Looks good. @phirvone could you also look at this. |
Trojan295
suggested changes
Feb 11, 2018
kong/plugins/oidc/handler.lua
Outdated
| local res, err = require("resty.openidc").introspect(oidcConfig) | ||
| if err then | ||
| if oidcConfig.bearer_only == "yes" then | ||
| ngx.header["WWW-Authenticate"] = 'Bearer realm="kong",error="' .. err .. '"' |
There was a problem hiding this comment.
Should realm here be hardcoded? IDP can have different realms and I think it should be also a configuration option.
There was a problem hiding this comment.
Also thought about that, but didn't want to overcomplicate the configuration. But now that I think again, I am all for a configurable realm with a sane default.
oidcConfig.bearer_only always resolved to true. Changed for oidcConfig.bearer_only == "yes".
Trojan295
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26.