Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for true as well as 'yes' to avoid confusion #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check for true as well as 'yes' to avoid confusion #146

wants to merge 1 commit into from

Conversation

ramirezd42
Copy link

@ramirezd42 ramirezd42 commented Dec 23, 2019 •
edited
Loading

With kong in DB-free mode, if you specify bearer_only: yes in your kong.yml file, it will get parsed as true which causes the check to fail since it uses oidcConfig.bearer_only == "yes"

This can be pretty confusing and tripped me up for a bit. I propose checking for true in addition to "yes"

This resolves:
#144

@coveralls
Copy link

coveralls commented Dec 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 144

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.324%
Totals Coverage Status
Change from base Build 134: 0.03%
Covered Lines: 393
Relevant Lines: 408
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramirezd42 @coveralls