Add verbatim LICENSE #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I'm working on VSCode and we would like to attribute your node module in our ThirdPartyNotices.txt (yay! we're shipping it!) We have a pretty basic automated generator that picks up LICENSE files from repositories and it is pretty standard that OSS projects have some form of license file at their root. It would be great if we could remove our custom rule we currently have in place for your repository (as it is missing a license file) and simply pick the license straight from your repository, with the wording you would like. This will also help other projects that want to consume your node module. Thanks, Alex
alexdima
added a commit
to microsoft/vscode
that referenced
this pull request
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm working on VSCode and we would like to attribute your node module in our ThirdPartyNotices.txt (yay! we're shipping it!)
We have a pretty basic automated generator that picks up LICENSE files from repositories and it is pretty standard that OSS projects have some form of license file at their root.
It would be great if we could remove our custom rule we currently have in place for your repository (as it is missing a license file) and simply pick the license straight from your repository, with the wording you would like.
This will also help other projects that want to consume your node module.
Thanks,
Alex