Skip to content

Commit

Permalink
Removing deprecated method (hyperledger#4741)
Browse files Browse the repository at this point in the history
* Replace deprecated method
* Ignore field

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
  • Loading branch information
gfukushima authored Nov 28, 2022
1 parent d2382c6 commit d5a1843
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ private void fromDomainObject(final D domainObject) {

final List<String> fieldsToIgnore = getFieldsToIgnore();
final String[] ignored = fieldsToIgnore.toArray(new String[0]);
assertThat(domainObjectFromOptions).isEqualToIgnoringGivenFields(domainObject, ignored);
assertThat(domainObjectFromOptions)
.usingRecursiveComparison()
.ignoringFields(ignored)
.isEqualTo(domainObject);
}

@Test
Expand Down Expand Up @@ -78,7 +81,10 @@ public void defaultValues() {

// Check default values supplied by CLI match expected default values
final String[] fieldsToIgnore = getFieldsWithComputedDefaults().toArray(new String[0]);
assertThat(optionsFromCommand).isEqualToIgnoringGivenFields(defaultOptions, fieldsToIgnore);
assertThat(optionsFromCommand)
.usingRecursiveComparison()
.ignoringFields(fieldsToIgnore)
.isEqualTo(defaultOptions);
}

abstract D createDefaultDomainObject();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
import org.hyperledger.besu.cli.options.unstable.NetworkingOptions;
import org.hyperledger.besu.ethereum.p2p.config.NetworkingConfiguration;

import java.util.Arrays;
import java.util.List;

import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;
Expand Down Expand Up @@ -212,4 +215,9 @@ NetworkingOptions optionsFromDomainObject(final NetworkingConfiguration domainOb
NetworkingOptions getOptionsFromBesuCommand(final TestBesuCommand besuCommand) {
return besuCommand.getNetworkingOptions();
}

@Override
protected List<String> getFieldsToIgnore() {
return Arrays.asList("rlpx.peerLowerBound");
}
}

0 comments on commit d5a1843

Please sign in to comment.