Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django.url can't handle optional trailing slash in URL regex #20

Closed
rouge8 opened this issue Jun 6, 2013 · 2 comments
Closed

Django.url can't handle optional trailing slash in URL regex #20

rouge8 opened this issue Jun 6, 2013 · 2 comments

Comments

@rouge8
Copy link
Contributor

rouge8 commented Jun 6, 2013

When a URL pattern has an optional trailing slash, _get_urls() matches the URL as url/? rather than url.

I pushed a failing test case in d78a140. I'm going to take a look at it in more detail later, but it didn't appear to be a trivial fix.
noirbizarre pushed a commit that referenced this issue Jun 6, 2013
@noirbizarre
Failing test case for #20.
80207e3
@rouge8
Copy link
Contributor Author

rouge8 commented Jun 7, 2013

Looks like that was easier than I thought. Thanks for the quick fix!

@noirbizarre
Copy link
Owner

Regex power !!!

You're welcome !
By the way, thanks for the reports and the many contributions !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noirbizarre @rouge8