Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foundry voting example<updated> #37

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

satyambnsal
Copy link

Description

Updated foundry voting example for Ultraplonk

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link

socket-security bot commented Jan 31, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link
Contributor

@signorecello signorecello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love that you shaved off 14k lines out of this haha. Just a quick suggestion if you're up for it

Copy link
Collaborator

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satyambnsal satyambnsal requested a review from critesjosh March 5, 2025 11:54
@critesjosh
Copy link
Collaborator

@satyambnsal im updating the foundry tests github actions file to try to get it running. i think there might be a bug on our side with it at the moment, but should be fixed soon

@critesjosh
Copy link
Collaborator

got the CI working. can you address the failing tests? https://github.com/noir-lang/noir-examples/actions/runs/13707654377/job/38350400576

@satyambnsal
Copy link
Author

got the CI working. can you address the failing tests? https://github.com/noir-lang/noir-examples/actions/runs/13707654377/job/38350400576

Awesome. I'll fix it today.

@satyambnsal
Copy link
Author

got the CI working. can you address the failing tests? https://github.com/noir-lang/noir-examples/actions/runs/13707654377/job/38350400576

Awesome. I'll fix it today.

I see this is happening because of issue in zk-kit repository.
I guess first I should fix that one.
privacy-scaling-explorations/zk-kit.noir#32

Copy link

socket-security bot commented Mar 12, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants