-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
foundry voting example<updated> #37
base: master
Are you sure you want to change the base?
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotta love that you shaved off 14k lines out of this haha. Just a quick suggestion if you're up for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Can you update the CI file as well? https://github.com/noir-lang/noir-examples/blob/master/.github/workflows/foundry-voting.yml
@satyambnsal im updating the foundry tests github actions file to try to get it running. i think there might be a bug on our side with it at the moment, but should be fixed soon |
got the CI working. can you address the failing tests? https://github.com/noir-lang/noir-examples/actions/runs/13707654377/job/38350400576 |
Awesome. I'll fix it today. |
I see this is happening because of issue in zk-kit repository. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Description
Updated foundry voting example for Ultraplonk
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmt
on default settings.