Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add article link to the README #40

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

kamranbekirovyz
Copy link
Contributor

Hi @nohli. Thanks for giving the chance to add my article to the README as a reference.

Please, look at the changes I've made. I did my best, but, let me know if we can improve the sentence.

@nohli
Copy link
Owner

nohli commented Jun 4, 2024

Cool, great job! Thank you for your contribution.

Here are a few suggestions to improve the code and documentation:

  1. Using haptic feedback instead of haptic feedbacks is more accurate. As well in this PR, as in the article. What do you think?

  2. In the article, await is missing before a few method calls.

  3. Consider changing the check from:

    if (_canVibrate ==true) {

to

    if (_canVibrate ?? false) {
  1. To prevent instantiation of the class and avoid suggestions from the code editor, add a private constructor:
HapticsHelper._();

Thanks again for your work on this. These changes can enhance the accuracy and robustness of the code.

@kamranbekirovyz
Copy link
Contributor Author

@nohli thanks, I'll update the article with the suggestions of yours and let you know.

kamranbekirovyz and others added 2 commits June 5, 2024 16:24
Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
@kamranbekirovyz kamranbekirovyz requested a review from nohli June 5, 2024 12:27
Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
@kamranbekirovyz kamranbekirovyz requested a review from nohli June 6, 2024 21:55
@nohli
Copy link
Owner

nohli commented Jun 7, 2024

Thanks for updating.

Have you looked at points 1-3 from my previous comment?

@kamranbekirovyz
Copy link
Contributor Author

Thanks for updating.

Have you looked at points 1-3 from my previous comment?

Yes. The first one is done, I even changed the title of the article. About the 3rd point, if you think it is very crucial I can update it right now.

@nohli
Copy link
Owner

nohli commented Jun 7, 2024

Regarding the article:

  1. I still notice numerous instances of haptic feedbacks.
  2. Additionally, there are still missing awaits before method calls.
  3. was referring to the no_literal_bool_comparisons linter rule: https://dart.dev/tools/linter-rules/no_literal_bool_comparisons (Effective Dart: https://dart.dev/effective-dart/usage#dont-use-true-or-false-in-equality-operations)

In my opinion, an article explaining code should be precise.

@kamranbekirovyz
Copy link
Contributor Author

kamranbekirovyz commented Jun 11, 2024

Regarding the article:

  1. I still notice numerous instances of haptic feedbacks.
  2. Additionally, there are still missing awaits before method calls.
  3. was referring to the no_literal_bool_comparisons linter rule: https://dart.dev/tools/linter-rules/no_literal_bool_comparisons (Effective Dart: https://dart.dev/effective-dart/usage#dont-use-true-or-false-in-equality-operations)

In my opinion, an article explaining code should be precise.

Updated the article again. Is there anything missing again?

@nohli
Copy link
Owner

nohli commented Jun 11, 2024

Regarding the article:

  1. I still notice numerous instances of haptic feedbacks.
  1. Additionally, there are still missing awaits before method calls.
  1. was referring to the no_literal_bool_comparisons linter rule: https://dart.dev/tools/linter-rules/no_literal_bool_comparisons (Effective Dart: https://dart.dev/effective-dart/usage#dont-use-true-or-false-in-equality-operations)

In my opinion, an article explaining code should be precise.

Updated the article again. Is there anything missing again?

Great, thanks for updating! 🙏🏽

I will merge asap.

There is still one instance of "haptic feedbacks", would be good to change it to "haptic feedback".

Explanation:
The term “haptic feedback” is typically used in the singular form, much like the words “information” or “data.” All these terms are collective nouns, meaning they refer to a concept that inherently includes multiple instances.

@kamranbekirovyz
Copy link
Contributor Author

Regarding the article:

  1. I still notice numerous instances of haptic feedbacks.
  1. Additionally, there are still missing awaits before method calls.
  1. was referring to the no_literal_bool_comparisons linter rule: https://dart.dev/tools/linter-rules/no_literal_bool_comparisons (Effective Dart: https://dart.dev/effective-dart/usage#dont-use-true-or-false-in-equality-operations)

In my opinion, an article explaining code should be precise.

Updated the article again. Is there anything missing again?

Great, thanks for updating! 🙏🏽

I will merge asap.

There is still one instance of "haptic feedbacks", would be good to change it to "haptic feedback".

Explanation: The term “haptic feedback” is typically used in the singular form, much like the words “information” or “data.” All these terms are collective nouns, meaning they refer to a concept that inherently includes multiple instances.

My pleasure.

Although, I think it should be "a set of haptic feedbacks" you and ChatGPT are in majority. So, changed that too.

@nohli
Copy link
Owner

nohli commented Jun 12, 2024

Regarding the article:

  1. I still notice numerous instances of haptic feedbacks.
  1. Additionally, there are still missing awaits before method calls.
  1. was referring to the no_literal_bool_comparisons linter rule: dart.dev/tools/linter-rules/no_literal_bool_comparisons (Effective Dart: dart.dev/effective-dart/usage#dont-use-true-or-false-in-equality-operations)

In my opinion, an article explaining code should be precise.

Updated the article again. Is there anything missing again?

Great, thanks for updating! 🙏🏽
I will merge asap.
There is still one instance of "haptic feedbacks", would be good to change it to "haptic feedback".
Explanation: The term “haptic feedback” is typically used in the singular form, much like the words “information” or “data.” All these terms are collective nouns, meaning they refer to a concept that inherently includes multiple instances.

My pleasure.

Although, I think it should be "a set of haptic feedbacks" you and ChatGPT are in majority. So, changed that too.

hahaha

Actually the first thing was I googled the plural version and didn't find results, only singular.

Copy link
Owner

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@nohli nohli merged commit c5ee8d3 into nohli:main Jun 12, 2024
@kamranbekirovyz kamranbekirovyz deleted the add-article-by-kamran branch June 12, 2024 16:15
@kamranbekirovyz
Copy link
Contributor Author

@nohli my pleasure to be featured on the README with my new Flutter blog. Thanks for the opportunity and, especially, your time.

@nohli
Copy link
Owner

nohli commented Jun 12, 2024

Thank you

I hope you have fun and success with your blog! 🤝🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants