-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add article link to the README #40
Conversation
Cool, great job! Thank you for your contribution. Here are a few suggestions to improve the code and documentation:
to
Thanks again for your work on this. These changes can enhance the accuracy and robustness of the code. |
@nohli thanks, I'll update the article with the suggestions of yours and let you know. |
Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
Thanks for updating. Have you looked at points 1-3 from my previous comment? |
Yes. The first one is done, I even changed the title of the article. About the 3rd point, if you think it is very crucial I can update it right now. |
Regarding the article:
In my opinion, an article explaining code should be precise. |
Updated the article again. Is there anything missing again? |
Great, thanks for updating! 🙏🏽 I will merge asap. There is still one instance of "haptic feedbacks", would be good to change it to "haptic feedback". Explanation: |
My pleasure. Although, I think it should be "a set of haptic feedbacks" you and ChatGPT are in majority. So, changed that too. |
hahaha Actually the first thing was I googled the plural version and didn't find results, only singular. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
@nohli my pleasure to be featured on the README with my new Flutter blog. Thanks for the opportunity and, especially, your time. |
Hi @nohli. Thanks for giving the chance to add my article to the README as a reference.
Please, look at the changes I've made. I did my best, but, let me know if we can improve the sentence.