Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated jQuery event shorthand #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevin-j-morse
Copy link

See https://github.com/jquery/jquery-migrate/blob/master/warnings.md

The current use of blur() and focus() trigger warnings for those of us running jquery-migrate

I noticed there is one other call to blur() and one other call to focus() but I believe those are to the vanilla JS versions of blur() and focus() not the jQuery versions so I don't think they should be changed.

FWIW, this fork fixes the jQuery Migrate warnings for me.

@marcandre
Copy link
Collaborator

Sorry I couldn't look at this earlier. Looks good, but the enclosing if should be changed too. Probably checking for if(! ...) would be best.

Would you be kind enough to amend your PR? I can't do it myself as I'm without access to a computer for almost two more weeks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants