Skip to content

Commit

Permalink
proc: remove proc_root_driver
Browse files Browse the repository at this point in the history
Use creation by full path: "driver/foo".

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Alexey Dobriyan authored and torvalds committed Apr 29, 2008
1 parent 36a5aeb commit 928b4d8
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 17 deletions.
4 changes: 2 additions & 2 deletions drivers/block/cciss.c
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ static void __devinit cciss_procinit(int i)
struct proc_dir_entry *pde;

if (proc_cciss == NULL)
proc_cciss = proc_mkdir("cciss", proc_root_driver);
proc_cciss = proc_mkdir("driver/cciss", NULL);
if (!proc_cciss)
return;
pde = proc_create(hba[i]->devname, S_IWUSR | S_IRUSR | S_IRGRP |
Expand Down Expand Up @@ -3700,7 +3700,7 @@ static void __exit cciss_cleanup(void)
cciss_remove_one(hba[i]->pdev);
}
}
remove_proc_entry("cciss", proc_root_driver);
remove_proc_entry("driver/cciss", NULL);
}

static void fail_all_cmds(unsigned long ctlr)
Expand Down
4 changes: 2 additions & 2 deletions drivers/block/cpqarray.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ static struct proc_dir_entry *proc_array;
static void __init ida_procinit(int i)
{
if (proc_array == NULL) {
proc_array = proc_mkdir("cpqarray", proc_root_driver);
proc_array = proc_mkdir("driver/cpqarray", NULL);
if (!proc_array) return;
}

Expand Down Expand Up @@ -1796,7 +1796,7 @@ static void __exit cpqarray_exit(void)
}
}

remove_proc_entry("cpqarray", proc_root_driver);
remove_proc_entry("driver/cpqarray", NULL);
}

module_init(cpqarray_init)
Expand Down
4 changes: 2 additions & 2 deletions drivers/block/pktcdvd.c
Original file line number Diff line number Diff line change
Expand Up @@ -3101,7 +3101,7 @@ static int __init pkt_init(void)
goto out_misc;
}

pkt_proc = proc_mkdir(DRIVER_NAME, proc_root_driver);
pkt_proc = proc_mkdir("driver/"DRIVER_NAME, NULL);

return 0;

Expand All @@ -3117,7 +3117,7 @@ static int __init pkt_init(void)

static void __exit pkt_exit(void)
{
remove_proc_entry(DRIVER_NAME, proc_root_driver);
remove_proc_entry("driver/"DRIVER_NAME, NULL);
misc_deregister(&pkt_misc);

pkt_debugfs_cleanup();
Expand Down
8 changes: 4 additions & 4 deletions drivers/net/wireless/airo.c
Original file line number Diff line number Diff line change
Expand Up @@ -5625,9 +5625,9 @@ static int __init airo_init_module( void )
int have_isa_dev = 0;
#endif

airo_entry = create_proc_entry("aironet",
airo_entry = create_proc_entry("driver/aironet",
S_IFDIR | airo_perm,
proc_root_driver);
NULL);

if (airo_entry) {
airo_entry->uid = proc_uid;
Expand All @@ -5651,7 +5651,7 @@ static int __init airo_init_module( void )
airo_print_info("", "Finished probing for PCI adapters");

if (i) {
remove_proc_entry("aironet", proc_root_driver);
remove_proc_entry("driver/aironet", NULL);
return i;
}
#endif
Expand All @@ -5673,7 +5673,7 @@ static void __exit airo_cleanup_module( void )
#ifdef CONFIG_PCI
pci_unregister_driver(&airo_driver);
#endif
remove_proc_entry("aironet", proc_root_driver);
remove_proc_entry("driver/aironet", NULL);
}

/*
Expand Down
5 changes: 1 addition & 4 deletions fs/proc/root.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@

#include "internal.h"

struct proc_dir_entry *proc_root_driver;

static int proc_test_super(struct super_block *sb, void *data)
{
return sb->s_fs_info == data;
Expand Down Expand Up @@ -127,7 +125,7 @@ void __init proc_root_init(void)
proc_mkdir("sysvipc", NULL);
#endif
proc_mkdir("fs", NULL);
proc_root_driver = proc_mkdir("driver", NULL);
proc_mkdir("driver", NULL);
proc_mkdir("fs/nfsd", NULL); /* somewhere for the nfsd filesystem to be mounted */
#if defined(CONFIG_SUN_OPENPROMFS) || defined(CONFIG_SUN_OPENPROMFS_MODULE)
/* just give it a mountpoint */
Expand Down Expand Up @@ -235,4 +233,3 @@ EXPORT_SYMBOL(create_proc_entry);
EXPORT_SYMBOL(proc_create);
EXPORT_SYMBOL(remove_proc_entry);
EXPORT_SYMBOL(proc_root);
EXPORT_SYMBOL(proc_root_driver);
3 changes: 0 additions & 3 deletions include/linux/proc_fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ struct vmcore {
#ifdef CONFIG_PROC_FS

extern struct proc_dir_entry proc_root;
extern struct proc_dir_entry *proc_root_driver;
extern struct proc_dir_entry *proc_root_kcore;

extern spinlock_t proc_subdir_lock;
Expand Down Expand Up @@ -211,8 +210,6 @@ extern void dup_mm_exe_file(struct mm_struct *oldmm, struct mm_struct *newmm);

#else

#define proc_root_driver NULL

#define proc_net_fops_create(net, name, mode, fops) ({ (void)(mode), NULL; })
static inline void proc_net_remove(struct net *net, const char *name) {}

Expand Down

0 comments on commit 928b4d8

Please sign in to comment.