Skip to content

Commit

Permalink
hwmon: Use platform_device_add_data()
Browse files Browse the repository at this point in the history 
Use platform_device_add_data() in hardware monitoring drivers. This
makes the code nicer and smaller too. Reported by David Hubbard.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: David Hubbard <david.c.hubbard@gmail.com>
  • Loading branch information
Jean Delvare authored and Mark M. Hoffman committed Jul 19, 2007
1 parent f641b58 commit 2df6d81
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 18 deletions.
9 changes: 3 additions & 6 deletions drivers/hwmon/f71805f.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1290,15 +1290,12 @@ static int __init f71805f_device_add(unsigned short address,
goto exit_device_put;
}

pdev->dev.platform_data = kmalloc(sizeof(struct f71805f_sio_data),
GFP_KERNEL);
if (!pdev->dev.platform_data) {
err = -ENOMEM;
err = platform_device_add_data(pdev, sio_data,
sizeof(struct f71805f_sio_data));
if (err) {
printk(KERN_ERR DRVNAME ": Platform data allocation failed\n");
goto exit_device_put;
}
memcpy(pdev->dev.platform_data, sio_data,
sizeof(struct f71805f_sio_data));

err = platform_device_add(pdev);
if (err) {
Expand Down
9 changes: 3 additions & 6 deletions drivers/hwmon/smsc47m1.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -693,15 +693,12 @@ static int __init smsc47m1_device_add(unsigned short address,
goto exit_device_put;
}

pdev->dev.platform_data = kmalloc(sizeof(struct smsc47m1_sio_data),
GFP_KERNEL);
if (!pdev->dev.platform_data) {
err = -ENOMEM;
err = platform_device_add_data(pdev, sio_data,
sizeof(struct smsc47m1_sio_data));
if (err) {
printk(KERN_ERR DRVNAME ": Platform data allocation failed\n");
goto exit_device_put;
}
memcpy(pdev->dev.platform_data, sio_data,
sizeof(struct smsc47m1_sio_data));

err = platform_device_add(pdev);
if (err) {
Expand Down
9 changes: 3 additions & 6 deletions drivers/hwmon/w83627hf.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1548,15 +1548,12 @@ static int __init w83627hf_device_add(unsigned short address,
goto exit_device_put;
}

pdev->dev.platform_data = kmalloc(sizeof(struct w83627hf_sio_data),
GFP_KERNEL);
if (!pdev->dev.platform_data) {
err = -ENOMEM;
err = platform_device_add_data(pdev, sio_data,
sizeof(struct w83627hf_sio_data));
if (err) {
printk(KERN_ERR DRVNAME ": Platform data allocation failed\n");
goto exit_device_put;
}
memcpy(pdev->dev.platform_data, sio_data,
sizeof(struct w83627hf_sio_data));

err = platform_device_add(pdev);
if (err) {
Expand Down

0 comments on commit 2df6d81

Please sign in to comment.